[MIRROR] Brings the captain's safe off the wall, safes now save their contents #2475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… contents (#1487) * Brings the captain's safe off the wall, safes now save their contents (#81762) ## About The Pull Request I originally was gonna make the captain's spare ID safe float in the air if the wall under it was taken down, but it looked poor and was going against the vision for wall items (and go against the wallening) so my alternative proposition is this, taking the safe off the wall. It's now a golden safe (like the one in the vault) but is interacted the exact same, it's now just a thing on the floor rather than being on a wall. I'm not a spriter so I didn't give it a custom icon but if anyone wants to they can feel free to add one, just a golden version of the regular safe felt kinda eh. I also added a wallframe version of the secure safe for when it is taken down. It will conserve its contents and be permanently locked until put back up. This doesn't apply to the new captain safe since it isn't a wall item. ## Why It's Good For The Game Closes tgstation/tgstation#80588 Prevents people from cheesing the spare and/or it being too easy to destroy. ## Changelog :cl: fix: The captain's safe is no longer on the wall, therefore cannot be cheesed by breaking the wall it sits on. fix: Tearing down a wall that a safe is on now drops the safe with its contents, rather than dropping the contents onto the floor. The safe's contents cannot be interacted with while it's not on a wall. /:cl: * Brings the captain's safe off the wall, safes now save their contents * Void and Blueshift --------- Co-authored-by: John Willard <[email protected]> Co-authored-by: SomeRandomOwl <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Mar 20, 2024
Iajret
pushed a commit
that referenced
this pull request
May 15, 2024
* Blood Brothers admin tooling (#83130) ## About The Pull Request  Makes it easier to see how many more people a Blood Brother can convert Also makes it easier to increment/decrement the number of people they can convert (for instance if they convert someone who immediately goes AFK, you can refund it). ## Why It's Good For The Game Admins were finding it kind of hard to figure out how to do this ## Changelog :cl: admin: Admins can now more easily modify whether a Blood Brother can convert someone /:cl: * Blood Brothers admin tooling --------- Co-authored-by: Jacquerel <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
May 16, 2024
* Blood Brothers admin tooling (#83130) ## About The Pull Request  Makes it easier to see how many more people a Blood Brother can convert Also makes it easier to increment/decrement the number of people they can convert (for instance if they convert someone who immediately goes AFK, you can refund it). ## Why It's Good For The Game Admins were finding it kind of hard to figure out how to do this ## Changelog :cl: admin: Admins can now more easily modify whether a Blood Brother can convert someone /:cl: * Blood Brothers admin tooling --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: Jacquerel <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1487
Original PR: tgstation/tgstation#81762
About The Pull Request
I originally was gonna make the captain's spare ID safe float in the air if the wall under it was taken down, but it looked poor and was going against the vision for wall items (and go against the wallening) so my alternative proposition is this, taking the safe off the wall.
It's now a golden safe (like the one in the vault) but is interacted the exact same, it's now just a thing on the floor rather than being on a wall.
I'm not a spriter so I didn't give it a custom icon but if anyone wants to they can feel free to add one, just a golden version of the regular safe felt kinda eh.
I also added a wallframe version of the secure safe for when it is taken down. It will conserve its contents and be permanently locked until put back up. This doesn't apply to the new captain safe since it isn't a wall item.
Why It's Good For The Game
Closes tgstation/tgstation#80588
Prevents people from cheesing the spare and/or it being too easy to destroy.
Changelog
🆑 JohnFulpWillard
fix: The captain's safe is no longer on the wall, therefore cannot be cheesed by breaking the wall it sits on.
fix: Tearing down a wall that a safe is on now drops the safe with its contents, rather than dropping the contents onto the floor. The safe's contents cannot be interacted with while it's not on a wall.
/:cl: