Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Puts Deathmatch map names, keys in line with each other (WARNING: LETHAL DOSES OF SNAKECASE INSIDE) #2476

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1514
Original PR: tgstation/tgstation#81970

About The Pull Request

This does a bunch of cleaning up with regards to Deathmatch map names, keys, filenames, etc.

Quick summary -- Filenames/map keys now have underscore spacing and have been mostly. Deathmatch now has its own root folder instead of just being in map_files (this might not really be necessary idk why I did this). Map filenames and map keys should be consistent now in terms of spacing, capitalization, and what they actually refer to.

Why It's Good For The Game

"Backalley" is actually called "raidthebase" internally. Arenastation doesn't use the "Arena" map, instead using the one called "Star Wars" (The underground thunderdome uses the "Arena" map, actually). Guess which one was internally called "chinatown" and get a prize!

This makes a lot of the map stuff related to Deathmatch easier to read and less inconsistent. I know consistency isn't super important but it annoys me personally and I need to address it.

Changelog

🆑 Rhials
code: Deathmatch files, map names, and keys should all be consistent now.
/:cl:

…NING: LETHAL DOSES OF SNAKECASE INSIDE) (#1514)

* Puts Deathmatch map names, keys in line with each other (WARNING: LETHAL DOSES OF SNAKECASE INSIDE) (#81970)

## About The Pull Request

This does a bunch of cleaning up with regards to Deathmatch map names,
keys, filenames, etc.

Quick summary -- Filenames/map keys now have underscore spacing and have
been mostly. Deathmatch now has its own root folder instead of just
being in map_files (this might not really be necessary idk why I did
this). Map filenames and map keys should be consistent now in terms of
spacing, capitalization, and what they actually refer to.

## Why It's Good For The Game

"Backalley" is actually called "raidthebase" internally. Arenastation
doesn't use the "Arena" map, instead using the one called "Star Wars"
(The underground thunderdome uses the "Arena" map, actually). Guess
which one was internally called "chinatown" and get a prize!

This makes a lot of the map stuff related to Deathmatch easier to read
and less inconsistent. I know consistency isn't super important but it
annoys me personally and I need to address it.
## Changelog
:cl: Rhials
code: Deathmatch files, map names, and keys should all be consistent
now.
/:cl:

* Puts Deathmatch map names, keys in line with each other (WARNING: LETHAL DOSES OF SNAKECASE INSIDE)

---------

Co-authored-by: Rhials <[email protected]>
@ReezeBL ReezeBL merged commit 87cfbc7 into master Mar 20, 2024
24 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-1514 branch March 20, 2024 07:26
AnywayFarus added a commit that referenced this pull request Mar 20, 2024
Iajret pushed a commit that referenced this pull request May 15, 2024
…I lawset boards and random pool. (#2476)

* Adds a new neutral lawset, the Y.E.S.M.A.N. lawset, to the AI lawset boards and random pool.

* Update game_options.txt

* Update game_options.txt

* Update game_options.txt

---------

Co-authored-by: Iamgoofball <[email protected]>
Co-authored-by: Bloop <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants