[MIRROR] Infrared Emitters use beam datums (As God intended) #2486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Infrared Emitters use beam datums (As God intended) (#82094) ## About The Pull Request Fixes #64459 Fixes #82052 , probably Fixes #79747 , probably Fixes #81443 Infrared emitters now use beam datums instead of making their own effects and trying to `Move` it out until it hits something This means 1. Infrared emitters are (probably) more responsive 2. Infrared emitters (probably) react to less things they shouldn't react to (such as projectiles) This also means - Infrared emitters (when visible) are emissive (and glow in the dark slightly). Kinda neat? If you don't want it you can obviously just make it invisible - You can limbo under beams? Maybe you can do that already? IDK Other notes - Beams no longer set their beam component's `x`, `y` directly, now using `forceMove`   https://github.com/tgstation/tgstation/assets/51863163/29b76b58-ef36-4c4a-a3b2-017b625389dd ## Changelog :cl: Melbert refactor: Infrared emitters now function better (or at least more how you would expect them) (hopefully). Report any oddities /:cl: * Infrared Emitters use beam datums (As God intended) --------- Co-authored-by: MrMelbert <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Mar 20, 2024
Iajret
pushed a commit
that referenced
this pull request
May 15, 2024
… it stops spamming logs (#2486) * Moves the departmental delivery area check to a unit test so it stops spamming logs (#83215) ## About The Pull Request So, thanks to the map not being loaded yet when jobs are initialized, the logs are needlessly spammed by a check that can never pass.  Also adds some possible locations to engineering and science As such, I just moved all this logging stuff and screaming at mappers/coders into a unit test. I honestly only have very vague understanding of how these work so someone with more knowledge please check if I did everything right. * Moves the departmental delivery area check to a unit test so it stops spamming logs --------- Co-authored-by: Waterpig <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
May 16, 2024
… it stops spamming logs (#2486) (#3323) * Moves the departmental delivery area check to a unit test so it stops spamming logs (#83215) ## About The Pull Request So, thanks to the map not being loaded yet when jobs are initialized, the logs are needlessly spammed by a check that can never pass.  Also adds some possible locations to engineering and science As such, I just moved all this logging stuff and screaming at mappers/coders into a unit test. I honestly only have very vague understanding of how these work so someone with more knowledge please check if I did everything right. * Moves the departmental delivery area check to a unit test so it stops spamming logs --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: Waterpig <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1539
Original PR: tgstation/tgstation#82094
About The Pull Request
Fixes #64459
Fixes #82052 , probably
Fixes #79747 , probably
Fixes #81443
Infrared emitters now use beam datums instead of making their own effects and trying to
Moveit out until it hits somethingThis means
This also means
Other notes
x,ydirectly, now usingforceMove2024-03-18.19-46-34.mp4
Changelog
🆑 Melbert
refactor: Infrared emitters now function better (or at least more how you would expect them) (hopefully). Report any oddities
/:cl: