Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Allow hemiplegic users to pick which side is disabled #2488

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1541
Original PR: tgstation/tgstation#81992

About The Pull Request

Broadly this code is copied over from the preference code used for picking prosthetic limbs, with a few changes to make it fit.
It also changes how the quirk displays in the medical records, now mentioning which side is disabled instead of just half their body.

Why It's Good For The Game

So of course, first and foremost, I want it personally.
I'm now running a hemiplegic character on Manuel, and I want to able to pick which side is hemiplegic to match me using heterochromatic eyes to make it look like they're missing an eye. It's minor, but I think it'd be nice.

Then, because of that, I think it'd be nice to have for posterity. If I want it, and I can code it, then the next person who wants it doesn't have to, y'know?

Lastly, gameplay-wise, it doesn't really matter which side is hemiplegic, you're permanently missing an arm and a leg either way. So I feel there's practically no 'powergaming concerns' to be had when it's this utter shitass to use regardless and the benefits to be gained would be infinitesimally small in comparison.

Changelog

🆑 00-Steven
add: Hemiplegic now lets you pick which side is disabled.
add: The medical records text for hemiplegics now shows which side is disabled.
/:cl:

* Allow hemiplegic users to pick which side is disabled (#81992)

## About The Pull Request

Broadly this code is copied over from the preference code used for
picking prosthetic limbs, with a few changes to make it fit.
It also changes how the quirk displays in the medical records, now
mentioning which side is disabled instead of just half their body.
## Why It's Good For The Game

So of course, first and foremost, I want it personally.
I'm now running a hemiplegic character on Manuel, and I want to able to
pick which side is hemiplegic to match me using heterochromatic eyes to
make it look like they're missing an eye. It's minor, but I think it'd
be nice.

Then, because of that, I think it'd be nice to have for posterity. If I
want it, and I can code it, then the next person who wants it doesn't
have to, y'know?

Lastly, gameplay-wise, it doesn't really matter which side is
hemiplegic, you're permanently missing an arm and a leg either way. So I
feel there's practically no 'powergaming concerns' to be had when it's
this utter shitass to use regardless and the benefits to be gained would
be infinitesimally small in comparison.
## Changelog
:cl:
add: Hemiplegic now lets you pick which side is disabled.
add: The medical records text for hemiplegics now shows which side is
disabled.
/:cl:

* Allow hemiplegic users to pick which side is disabled

---------

Co-authored-by: _0Steven <[email protected]>
@ReezeBL ReezeBL merged commit 161d191 into master Mar 20, 2024
24 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-1541 branch March 20, 2024 07:33
AnywayFarus added a commit that referenced this pull request Mar 20, 2024
Iajret pushed a commit that referenced this pull request May 19, 2024
* strangified

* oops

* code that sucks less

---------

Co-authored-by: Hatterhat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants