Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] [NO-GBP] Genetic sequencer scanning makeup now detects when targets moves out of range #2490

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1543
Original PR: tgstation/tgstation#82092

About The Pull Request

Does what it says on the tin, adds a missing target argument in the timer function

Why It's Good For The Game

Changelog

🆑 Singul0
fix: You can't complete a genetic makeup scan when the targets moves out of target anymore using a genetic sequencer
/:cl:

…targets moves out of range (#1543)

* [NO-GBP] Genetic sequencer scanning makeup now detects when targets moves out of range (#82092)

## About The Pull Request
Does what it says on the tin, adds a missing target argument in the
timer function
## Why It's Good For The Game
## Changelog
:cl:
fix: You can't complete a genetic makeup scan when the targets moves out
of target anymore using a genetic sequencer
/:cl:

* [NO-GBP] Genetic sequencer scanning makeup now detects when targets moves out of range

---------

Co-authored-by: Singul0 <[email protected]>
@ReezeBL ReezeBL merged commit b9e5774 into master Mar 22, 2024
24 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-1543 branch March 22, 2024 06:33
AnywayFarus added a commit that referenced this pull request Mar 22, 2024
Iajret pushed a commit that referenced this pull request May 15, 2024
* parrots try to immitate voices (#82773)

## About The Pull Request
whenever parrots repeat lines they will try to mimic the speaker's
voice. it wont sound exact but theyre trying their best

## Why It's Good For The Game
adds more detail and character to the line repeating feature 

## Changelog
:cl:
add: parrots will now try to immitate the speaker's voice
/:cl:

* parrots try to immitate voices

---------

Co-authored-by: Ben10Omintrix <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
ReezeBL pushed a commit that referenced this pull request May 16, 2024
* parrots try to immitate voices (#82773)

## About The Pull Request
whenever parrots repeat lines they will try to mimic the speaker's
voice. it wont sound exact but theyre trying their best

## Why It's Good For The Game
adds more detail and character to the line repeating feature 

## Changelog
:cl:
add: parrots will now try to immitate the speaker's voice
/:cl:

* parrots try to immitate voices

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: Ben10Omintrix <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants