[MIRROR] Fixes an odd bug with record consoles #2495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes an odd bug with record consoles (#82103) ## About The Pull Request 1. Record computers never had ``character_preview_view`` set because it was never returned, and it was additionally never deleted. This caused an odd bug that, if you joined a round, ghosted, sent yourself back to lobby, then rejoined, record consoles would no longer have a character preview view. This fixes that, and also adds a define because I didn't like the copypasta it had going on. Security records currently have a big difference from the previous version in that every person on the UI sees their own thing (it's local instead of shared), which is a bigger problem that affects the whole computer and really should be addressed. This PR compliments tgstation/tgstation#82105 - This was a bug I found while working on that. ## Why It's Good For The Game Fixes an odd bug with security records that I've been trying to find out the cause to for a while. ## Changelog :cl: fix: Clients joining a round twice as a crewmember (via admins or otherwise) no longer break security/medical record consoles permanently. /:cl: * Fixes an odd bug with record consoles --------- Co-authored-by: John Willard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1550
Original PR: tgstation/tgstation#82103
About The Pull Request
character_preview_viewset because it was never returned, and it was additionally never deleted. This caused an odd bug that, if you joined a round, ghosted, sent yourself back to lobby, then rejoined, record consoles would no longer have a character preview view. This fixes that, and also adds a define because I didn't like the copypasta it had going on.Security records currently have a big difference from the previous version in that every person on the UI sees their own thing (it's local instead of shared), which is a bigger problem that affects the whole computer and really should be addressed.
This PR compliments tgstation/tgstation#82105 - This was a bug I found while working on that.
Why It's Good For The Game
Fixes an odd bug with security records that I've been trying to find out the cause to for a while.
Changelog
🆑 JohnFulpWillard
fix: Clients joining a round twice as a crewmember (via admins or otherwise) no longer break security/medical record consoles permanently.
/:cl: