Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTIS #2523

Merged
merged 49 commits into from Apr 16, 2024
Merged

NTIS #2523

merged 49 commits into from Apr 16, 2024

Conversation

ghost
Copy link

@ghost ghost commented Mar 23, 2024

О Pull Request

Полиция для НТРа, консоль для НТРа. Всё для НТРа.

Доказательства тестирования

Картиночке

изображение

изображение

изображение

изображение

Changelog

🆑
add: NTIS for NTR
add: Personal communication console for NTR
/:cl:

@ReezeBL
Copy link
Contributor

ReezeBL commented Mar 25, 2024

Тут коммитов больше чем у меня в среднем в проекте целом..

@ghost
Copy link
Author

ghost commented Mar 25, 2024

Тут коммитов больше чем у меня в среднем в проекте целом..

Я... Я просто по выходным пилил. И на учёбе. Как только у меня запускался бьонд и не срал - я коммитил хD

@JlereHda3oHbl1984
Copy link
Contributor

Всё. Теперь точно всё. Если только косяки какие не найдёте.

за нахождение косяков предусмотрена статья уголовного кодекса

Copy link
Collaborator

@Iajret Iajret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вех получается. Мне лень думать, только это глаз порезало. Копипасту мы (наверное нет) как-нибудь потом посмотрим, можно ли поправить в адекватное. Плюс, я не смотрел жсх.

tff_modular/modules/modular_automapper/replacer.dm Outdated Show resolved Hide resolved
@Iajret Iajret added the Feature label Mar 25, 2024
@ghost ghost requested a review from Iajret March 26, 2024 05:40
@Iajret
Copy link
Collaborator

Iajret commented Mar 26, 2024

ждём жидкий фак-ап от нас в раунде 8273

@ghost
Copy link
Author

ghost commented Apr 1, 2024

Оч надеюсь что ничего не сломал...

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself.

@github-actions github-actions bot added the Stale label Apr 11, 2024
@Iajret Iajret removed the Stale label Apr 11, 2024
@Iajret Iajret merged commit 625c944 into Fluffy-Frontier:master Apr 16, 2024
24 checks passed
AnywayFarus added a commit that referenced this pull request Apr 16, 2024
Iajret pushed a commit that referenced this pull request May 17, 2024
* Adds Minecarts (#83175)

## About The Pull Request

Designed for use in #83163 , not implemented anywhere else currently. 

Mining cars (existing crate reskin) now have a hefty drag slowdown. 
Click-dragging them onto a minecart rail (new), however, will negate
this slowdown, allowing you to drag them at nearly full speed.
This also gives you the opportunity to give them a bump to push them
down the tracks at a decent pace.


https://github.com/tgstation/tgstation/assets/51863163/293adbfb-e2bd-49ba-beef-c998c388ecf0

Other notes: 
- Running a cable underneath a minecart (underfloor allowed) will power
the rail, keeping its momentum, or boosting it slightly if it falls
below certain thresholds.
- If the minecart comes to an abrupt stop with a decent amount of speed,
it will chuck all of its contents ahead a few tiles.
- Break rails also exist, and stop the cart instantly (and with no
contents chucking) when powered with cable.
- The cart does hurt people who are standing in the way if it's moving
with moderate speed.
- And it also hurts people lying on the tracks. 
- You can buckle yourself onto a (closed) minecart to ride it. Someone
else has to give you a push though.

## Why It's Good For The Game

I was struggling to come up with a method of bulk transferring items for
the linked PR that didn't seem too contrived (bluespace BS, pods),
wouldn't require work refactoring an existing system (transit tubes),
and wasn't a tram, and I realized we have mine carts but no rails.

So I added rails and made the minecarts work on the rails. This gives a
method of shipping items from point A to point B that fits well in
certain settings, such as the lower areas of Icebox, or maybe in space
ruins.

I also think it would be fun to give miners some tools to construct
rails, to let them ship boulders back to the station via railway rather
than using teleportation.

## Changelog

:cl: Melbert
add: Adds Minecarts, (possibly admin only depending on when this PR is
merged in relation to the Icebox Bar PR)
/:cl:

* Adds Minecarts

---------

Co-authored-by: MrMelbert <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants