[MIRROR] Fix "Overweight" trait unintended interaction #2535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix "Overweight" trait unintended interaction The hunger hud update changed how the Overweight trait is handled, making it give any character using it the speed malus that the trait already gives, but also giving them an extra speed malus as if they were overfed at all times. Currently there's no way to get rid of the permanently overfed state without manually removing the "Overweight" trait directly from the mob that has it, this PR removes that permanent overfed state. * I think this is right? proper removal documentation, sans module since uh... dunno if it needs to be modularized * New Solution much easier to just make a new trait define, and then apply that new trait to where the old, conflicting one was being applied. * add new trait to _globalvars * Update code/_onclick/hud/screen_objects.dm Co-authored-by: Bloop <[email protected]> * upstream fix integration trait now adds the trait that was added upstream `TRAIT_OFF_BALANCE_TACKLER`. Which handles the only effect that we need to handle independently of `TRAIT_FAT` now. --------- Co-authored-by: Bloop <[email protected]>
…into upstream-mirror-1364
AnywayFarus
added a commit
that referenced
this pull request
Mar 25, 2024
Iajret
pushed a commit
that referenced
this pull request
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#1364
About The Pull Request
The hunger hud update changed how
TRAIT_FATtrait is handled, making it so that the "Overweight" quirk can no longer apply that trait without causing a lot of issues with the new hunger hud and how nutrition states are being tracked. This PR was partially solved upstream via NovaSector/NovaSector#1576. Only thing this PR does is fix the quirk to use that newly added trait. (Fixes #1322)How This Contributes To The Nova Sector Roleplay Experience
Fixes the overweight quirk so you're no longer irrevocably slowed and locked out of using the nutrition system properly.
Proof of Testing
Screenshots/Videos
Most of the videos I recorded are too large to be uploaded, but this is one of the issues that's solved via the changes. Mobs are no longer in the perma-fat state even though they shouldn't be. Can probably figure out how to get the rest of the videos uploaded somewhere if needed.Issue2.mp4
Changelog
🆑 Varoxus
fix: Overweight trait no longer interferes with the nutrition system
/:cl: