[MIRROR] Fixes lua error logging and a few timer.lua functions #2540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes lua error logging and a few timer.lua functions * Update lua_state.dm --------- Co-authored-by: Watermelon914 <[email protected]> Co-authored-by: Bloop <[email protected]>
Steals-The-PRs
added
Mirroring conflict
…into upstream-mirror-1591
AnywayFarus
added a commit
that referenced
this pull request
Mar 25, 2024
Iajret
pushed a commit
that referenced
this pull request
May 18, 2024
* Micro-optimizes _SendSignal a bit (#83244) ## About The Pull Request Instead of iterating over an assoc list and doing a list access, which has a complexity of O(nlog(n)), it is better to just store a 2 tuple and access that to get a complexity of O(n) Check code to see what I mean. ## Why It's Good For The Game  This is a very hot proc and it's worth micro-optimizing where we can. The speed increase in doing the following code can be seen here:  Higher is better. The code that was benchmarked: ```dm var/list/target = list() /proc/testa() var/list/queued_calls = list() for(var/i in 1 to length(target)) var/data = target[i] queued_calls.Add(data, 1) for(var/i in 1 to (length(queued_calls) / 2)) var/a = queued_calls[i*2-1] var/b = queued_calls[i*2] /proc/testb() var/list/queued_calls = list() for(var/data in target) queued_calls[data] = 1 for(var/data in queued_calls) var/a = data var/b = queued_calls[data] MAIN for(var/i in 1 to 100) target.Add("[i]") BEGIN_BENCH(2) BENCH_PHASE("New code", testa()) BENCH_PHASE("Old code", testb()) END_BENCH ``` ## Changelog --------- Co-authored-by: Watermelon914 <[email protected]> Co-authored-by: LemonInTheDark <[email protected]> * Micro-optimizes _SendSignal a bit --------- Co-authored-by: Watermelon914 <[email protected]> Co-authored-by: Watermelon914 <[email protected]> Co-authored-by: LemonInTheDark <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1591
Original PR: tgstation/tgstation#82160
About The Pull Request
Lua errors don't get logged when
call_functionis calledTimer.start_loop was just straight up broken due to me not properly testing it, so this fixes that.
Why It's Good For The Game
Makes debugging lua scripts easier. Also fixes bugs.
Changelog
🆑 Watermelon914
fix: Fixed lua error logging.
fix: Fixed the SS13.start_loop function not working properly.
/:cl: