[MIRROR] Blocks (most instances of) screen elements from entering base atom /Click
#2574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e atom `/Click` (#1646) * Blocks (most instances of) screen elements from entering base atom `/Click` (#82236) ## About The Pull Request Fixes #76495 This PR prevents (most) screen elements from running base `/atom/proc/Click` and `/mob/proc/ClickOn()` when clickend. (The only exception I found to it was the cursor catcher for scopes.) Why? Most, if not everything in `ClickOn` is considered "in world" interacting. It abides by `incapacitated`, runs `faceAtom`, etc. This means, currently, you can "interact" with screen elements using in world elements. For example, TK-ing / pointing a gun at your mood face. Right now this affects very little, but there is a large potential for errors. All you have to do is forget a sanity check in `afterattack` and suddenly you have an item that can affect your screen objects. The only example I found was the `/item/godstaff`, which can color some of your screen elements. But there may be more. Like guns. Note: Many, many screen elements ALREADY do not fall down into atom click. They simply don't call parent. Which is totally fine. I am just ensuring ALL* screen elements do not fall down into atom click. ## Changelog :cl: Melbert fix: Blocks mobs from trying to "physically" interact with some of their hud elements, such as using Telekinesis or point a gun at your mood meter. /:cl: * Blocks (most instances of) screen elements from entering base atom `/Click` --------- Co-authored-by: MrMelbert <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Mar 26, 2024
Iajret
pushed a commit
that referenced
this pull request
May 20, 2024
* Advanced Health Analysers can detect certain organs * Update surgery.dm * Update screenshot_humanoids__datum_species_moth.png --------- Co-authored-by: Jacquerel <[email protected]> Co-authored-by: SomeRandomOwl <[email protected]> Co-authored-by: Mal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1646
Original PR: tgstation/tgstation#82236
About The Pull Request
Fixes #76495
This PR prevents (most) screen elements from running base
/atom/proc/Clickand/mob/proc/ClickOn()when clickend.(The only exception I found to it was the cursor catcher for scopes.)
Why?
Most, if not everything in
ClickOnis considered "in world" interacting. It abides byincapacitated, runsfaceAtom, etc.This means, currently, you can "interact" with screen elements using in world elements. For example, TK-ing / pointing a gun at your mood face.
Right now this affects very little, but there is a large potential for errors. All you have to do is forget a sanity check in
afterattackand suddenly you have an item that can affect your screen objects.The only example I found was the
/item/godstaff, which can color some of your screen elements. But there may be more. Like guns.Note:
Many, many screen elements ALREADY do not fall down into atom click. They simply don't call parent. Which is totally fine.
I am just ensuring ALL* screen elements do not fall down into atom click.
Changelog
🆑 Melbert
fix: Blocks mobs from trying to "physically" interact with some of their hud elements, such as using Telekinesis or point a gun at your mood meter.
/:cl: