[MIRROR] Fix robocontrol access runtime #2584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix robocontrol access runtime (#82242) ## About The Pull Request  `check_access` expects an item, such as an ID card, to... check access. Not a mob. We can circumvent this entirely by using `allowed`. But this has an averse effect in that `allowed` will only check the user's ID, not the ID in the mod PC. So we need to run a separate check of `check_access` for the computer ID card. ## Changelog :cl: Melbert fix: Robocontrol should work better. /:cl: --------- Co-authored-by: san7890 <[email protected]> * Fix robocontrol access runtime --------- Co-authored-by: MrMelbert <[email protected]> Co-authored-by: san7890 <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Mar 27, 2024
Iajret
pushed a commit
that referenced
this pull request
May 20, 2024
* Sets cache lifespan to 0 * Update world.dm --------- Co-authored-by: Watermelon914 <[email protected]> Co-authored-by: Bloop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1655
Original PR: tgstation/tgstation#82242
About The Pull Request
check_accessexpects an item, such as an ID card, to... check access. Not a mob.We can circumvent this entirely by using
allowed.But this has an averse effect in that
allowedwill only check the user's ID, not the ID in the mod PC.So we need to run a separate check of
check_accessfor the computer ID card.Changelog
🆑 Melbert
fix: Robocontrol should work better.
/:cl: