Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Adds Rake and Cultivator so players can be self sufficient in hermits #2591

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1667
Original PR: tgstation/tgstation#82219

About The Pull Request

Added both a rake and a cultivator to the icemoon underground hermit ruin structure. This is to allow complete ability to operate without extra tools from external sources.

Why It's Good For The Game

It means ghosts(or visitors) can fully utilise this area and aren't hindered by being unable to remove any weeds etc.

Closes #81743

🆑 icequibe
qol: Allowed players to fully use the underground hermits without assistance outside of ruin
/:cl:

…n hermits (#1667)

* Adds Rake and Cultivator so players can be self sufficient in hermits (#82219)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Added both a rake and a cultivator to the icemoon underground hermit
ruin structure. This is to allow complete ability to operate without
extra tools from external sources.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
It means ghosts(or visitors) can fully utilise this area and aren't
hindered by being unable to remove any weeds etc.
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->

Closes #81743 

🆑 icequibe
qol: Allowed players to fully use the underground hermits without
assistance outside of ruin
/🆑
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

* Adds Rake and Cultivator so players can be self sufficient in hermits

---------

Co-authored-by: Trey Gyory <[email protected]>
@Iajret Iajret merged commit d7bf985 into master Mar 28, 2024
24 checks passed
AnywayFarus added a commit that referenced this pull request Mar 28, 2024
@Iajret Iajret deleted the upstream-mirror-1667 branch March 28, 2024 12:53
Iajret pushed a commit that referenced this pull request May 21, 2024
* Viewing Reticence Stats no longer causes NtOS error (#83343)

## About The Pull Request
These changes correctly place Reticence's default power module into a
`list()` object, preventing an NtOS error when using the "View Stats"
button inside the mech. This resolves a bug in the UI, which had
prevented players from viewing their Reticence mech's stats, and
modifying its loaded modules therein.

Closes #82374

Before:

![reticence-before](https://github.com/tgstation/tgstation/assets/5588048/9c90e7f2-13b6-49bb-af9b-6ad68834bfd4)


After:

![reticence-after](https://github.com/tgstation/tgstation/assets/5588048/96862f04-cc00-4d6f-bdeb-c34193794ab5)
## Why It's Good For The Game
Syndicate Mimes can now scream (inaudibly) for joy, as they'll be able
to inspect and modify their mech as was intended.
## Changelog
:cl:
fix: Viewing Reticence's stats no longer causes an NtOS UI error
/:cl:

* Viewing Reticence Stats no longer causes NtOS error

---------

Co-authored-by: Antonio Tosti <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants