[MIRROR] Cleans up blood deficiency hardcoding #2592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Cleans up blood deficiency hardcoding * Modular * No mail goodies --------- Co-authored-by: MrMelbert <[email protected]> Co-authored-by: Mal <[email protected]> Co-authored-by: SomeRandomOwl <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Mar 28, 2024
Iajret
pushed a commit
that referenced
this pull request
May 21, 2024
* add smoke kit to uplink (#83330) ## About The Pull Request Add smoke kit (5 grenades) by 2 TC ## Why It's Good For The Game Smokes can be a good addition for stealth implant, vanishing and slicing with a katana ## Proof of Testing <details> <summary>Screenshots/Videos OLD</summary>   </details> ## Changelog :cl: add: Added smoke kit (5 grenades) with four grenades to uplink by 2 TC /:cl: --------- Co-authored-by: Helg2 <[email protected]> * add smoke kit to uplink --------- Co-authored-by: hack-wrench <[email protected]> Co-authored-by: Helg2 <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1605
Original PR: tgstation/tgstation#82185
About The Pull Request
get_quirk, much like you canGetComponentgenerally speaking it's much cleaner to do it via signals.handle_blood.spec_lifeand running it off the signal.Why It's Good For The Game
Ye olde "consistency and cleaner code". And probably a tiny but of optimization to be yeeked out of it since we don't need to iterate over a mob's quirk list every life tick, nor every time we change specieses. But that's probably not even a drop in the bucket so not even worth mentioning.
Blood defi still happens in sync with Life (as noted by the comment).
Changelog
🆑 Melbert
refactor: Blood deficiency and slimepeople now handle blood a tiny bit differently, report any oddities.
refactor: Blood deficiency now handles its mail goods a tiny bit different, report any oddities.
/:cl: