[MIRROR] Prevents Debug ID Card from Polluting Cargo Budget By Doing It Right #2593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…It Right (#1670) * Prevents Debug ID Card from Polluting Cargo Budget By Doing It Right (#82214) ## About The Pull Request Fixes #81755 Alright instead of piggybacking off the departmental/non-departmental distinction and prevent ourselves from constantly abusing the cargo budget in order to achieve the very-specific effect of not wanting players to abuse this card in certain contexts let's just leverage the framework and expand it so that we can snowflake for admin/`holder` use cases in stuff like debugging code on a local server while preventing some player from stealing it off a newbie admin and immediately wrecking the economy (although it is funny). ## Why It's Good For The Game Probably a bad idea to continue to abuse the cargo budget like this since the only reason why it's structured that way is just for specific use-case exemptions in certain contexts - let's just do our own thing now :3 ## Changelog :cl: admin: Advanced Debug Cards will still provide a whole lot of access, but the way the money on those cards work is now a bit different. Players shouldn't be able to use the money on those cards in any context though, don't fret about that. Just know that the money printer goes wrrrr /:cl: --------- Co-authored-by: Zephyr <[email protected]> * Prevents Debug ID Card from Polluting Cargo Budget By Doing It Right --------- Co-authored-by: san7890 <[email protected]> Co-authored-by: Zephyr <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Mar 28, 2024
Iajret
pushed a commit
that referenced
this pull request
May 21, 2024
* Fix Crew Monitor scrolling breaking once focused (#83348) ## About The Pull Request Due to the nested scrollable section that grows to fill once focused you can no longer scroll the outer window using the wheel. Very annoying especially for us sillycones. This PR removes the inner scrollbar that never scrolls anyway, but is happy to eat your inputs.  ## Why It's Good For The Game Functional UI good. QOL good. ## Changelog :cl: qol: Crew Monitor UI now scrolls properly even after clicking the inner list. /:cl: * Fix Crew Monitor scrolling breaking once focused * converts to tsx, adds search * Update crew.dm * Update code/game/machinery/computer/crew.dm Co-authored-by: Bloop <[email protected]> --------- Co-authored-by: Wayland-Smithy <[email protected]> Co-authored-by: NovaBot13 <[email protected]> Co-authored-by: Zergspower <[email protected]> Co-authored-by: Bloop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1670
Original PR: tgstation/tgstation#82214
About The Pull Request
Fixes #81755
Alright instead of piggybacking off the departmental/non-departmental distinction and prevent ourselves from constantly abusing the cargo budget in order to achieve the very-specific effect of not wanting players to abuse this card in certain contexts let's just leverage the framework and expand it so that we can snowflake for admin/
holderuse cases in stuff like debugging code on a local server while preventing some player from stealing it off a newbie admin and immediately wrecking the economy (although it is funny).Why It's Good For The Game
Probably a bad idea to continue to abuse the cargo budget like this since the only reason why it's structured that way is just for specific use-case exemptions in certain contexts - let's just do our own thing now :3
Changelog
🆑 san7890
admin: Advanced Debug Cards will still provide a whole lot of access, but the way the money on those cards work is now a bit different. Players shouldn't be able to use the money on those cards in any context though, don't fret about that. Just know that the money printer goes wrrrr
/:cl: