Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Adds some generic species lore, descriptions, etc. to a few species #2644

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1619
Original PR: tgstation/tgstation#82162

About The Pull Request

Adds lore, descriptions, and pref perk setups to Abductors, Androids, Jellypeople, Golems, Podpeople, and Snailpeople

This PR does not imply nor implicate any intent to make any of the species roundstart species.

Note: All the lore and descriptions created were intended to be extremely generic to work with "future lore", IE essentially just temp lore. Suggestions are welcome.

Why It's Good For The Game

This kind of stuff is good to have setup in case rogue admins, station traits, or monthly events make these species roundstart.

See: Monkies. Which have a fully setup pref page for Monkey Day.

Changelog

🆑 Melbert
qol: A few species (such as Jellypeople) now have proper(ish) preference menu setups
config: The in-repo species config has been updated. Well it's still the same by default, but it's now updated for newer species.
/:cl:

…species (#1619)

* Adds some generic species lore, descriptions, etc. to a few species (#82162)

Adds lore, descriptions, and pref perk setups to Abductors, Androids,
Jellypeople, Golems, Podpeople, and Snailpeople

species roundstart species.

Note: All the lore and descriptions created were intended to be
extremely generic to work with "future lore", IE essentially just temp
lore. Suggestions are welcome.

This kind of stuff is good to have setup in case rogue admins, station
traits, or monthly events make these species roundstart.

See: Monkies. Which have a fully setup pref page for Monkey Day.

:cl: Melbert
qol: A few species (such as Jellypeople) now have proper(ish) preference
menu setups
config: The in-repo species config has been updated. Well it's still the
same by default, but it's now updated for newer species.
/:cl:

---------

Co-authored-by: jimmyl <[email protected]>

* Adds some generic species lore, descriptions, etc. to a few species

* Fixes all the screenshot tests

* Update game_options.txt

---------

Co-authored-by: MrMelbert <[email protected]>
Co-authored-by: jimmyl <[email protected]>
Co-authored-by: Mal <[email protected]>
@Steals-The-PRs Steals-The-PRs added Configs Mirroring conflict git cherry-pick во что-то уткнулся. Не ставить вручную, только для бота TG Mirror labels Mar 29, 2024
@ReezeBL
Copy link
Contributor

ReezeBL commented Mar 31, 2024

Блять, тут 2 рантайма из-за тараканов на айс боксе. Какого хуя????

@ReezeBL ReezeBL merged commit b4f40d6 into master Apr 3, 2024
23 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-1619 branch April 3, 2024 06:27
AnywayFarus added a commit that referenced this pull request Apr 3, 2024
Iajret pushed a commit that referenced this pull request May 24, 2024
…garette boxes onto the floor. (#2644)

* Fixes vendors displaying a broken character when dropping cigarette boxes onto the floor. (#83379)

## About The Pull Request

Vendors dispensing cigarette boxes onto the floor would cause a broken
character to appear at the beginning of the line.
Looking into it, this seemed to be due to an attempt at capitalizing the
item names, which interacts with the `\improper` text macro to cause
this issue.
Calling `format_text(...)` beforehand resolves this issue.

Look in the linked issue for more details.
## Why It's Good For The Game

Fixes #82618.
## Changelog
:cl:
spellcheck: When a vendor tells you something dropped onto the floor,
the line no longer starts with a broken character in the case of
cigarette boxes.
/:cl:

* Fixes vendors displaying a broken character when dropping cigarette boxes onto the floor.

---------

Co-authored-by: _0Steven <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Config Configs Mirroring conflict git cherry-pick во что-то уткнулся. Не ставить вручную, только для бота TG Mirror
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants