[MIRROR] [No GBP] Fixes a slime speed config and ai controller null error in slime nutrition handling #2689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rror in slime nutrition handling (#1748) * [No GBP] Fixes a slime speed config and ai controller null error in slime nutrition handling (#82330) ## About The Pull Request Someone has linked the runtimes logs of round 226376 to show off a runtime, and I took a look, and found some unrelated runtimes in slime code. - The config file for slime slowdown was still using the simple_animal path. This has been fixed. - Somehow, a grey slime has lost its AI controller, and when it got hungry, it runtimed. For now, a coalesce operator has been put in place. Later, an investigation is needed to figure out where did its AI controller go. ## Why It's Good For The Game Runtimes bad. ## Changelog :cl: fix: Slime properly load their slowdown values from the config files. fix: Slimes who lose their AI controller will no longer runtime when they get hungry. /:cl: * [No GBP] Fixes a slime speed config and ai controller null error in slime nutrition handling --------- Co-authored-by: Profakos <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Apr 1, 2024
Iajret
pushed a commit
that referenced
this pull request
May 27, 2024
…2689) * Vines can't pull anchored objects, can pull you off tables (#83410) ## About The Pull Request Fixes #83072 by preventing the ability from targeting anchored atoms. Also fixes the logic to only check for obstacles interposed between us and the target, not ones sharing the tile. ## Why It's Good For The Game This is how the ability was already supposed to work ## Changelog :cl: fix: Venus Man Traps cannot use vines to drag around machines or objects that are bolted, welded, rooted to, or otherwise are part of the ground fix: Standing on a table will not prevent you from being grappled by a Venus Man Trap /:cl: * Vines can't pull anchored objects, can pull you off tables --------- Co-authored-by: Jacquerel <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1748
Original PR: tgstation/tgstation#82330
About The Pull Request
Someone has linked the runtimes logs of round 226376 to show off a runtime, and I took a look, and found some unrelated runtimes in slime code.
Why It's Good For The Game
Runtimes bad.
Changelog
🆑 Profakos
fix: Slime properly load their slowdown values from the config files.
fix: Slimes who lose their AI controller will no longer runtime when they get hungry.
/:cl: