[MIRROR] Removes Space Dragon Final Objective #2701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removes Space Dragon Final Objective (#82259) ## About The Pull Request See title I left the item in and removed the antagonist checks from it just in case an admin wants to fuck around with it, but I can delete that too if preferred. ## Why It's Good For The Game This is both our least interesting and least impactful objective. Turning into a (nerfed) space dragon sort of looks cool maybe the first time you do it and then after that it isn't. It is sort of disappointing to see it pop up in the uplink, in my experience. This Space Dragon generally speaking isn't going to cause significant death or destruction except on lowpop (where a traitor can just do that anyway) or if they play in the cheesiest possible manner, it simply isn't that dangerous by itself. It is also simply less versatile than just _being a traitor with a lot of TC_, something you already are when you get it. Turning into a big animal also just doesn't feel much like something a traitor should be doing, that's a changeling or possibly wizard sort of objective. It also sort of cheapens "real" space dragons by making them show up this way. Finally; I just don't like it. We have enough final objectives now that we don't need to keep this one just to fill the pool, in my opinion. ## Changelog :cl: balance: Traitors can no longer turn themselves into dragons. /:cl: * Removes Space Dragon Final Objective --------- Co-authored-by: Jacquerel <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Apr 3, 2024
Iajret
pushed a commit
that referenced
this pull request
May 27, 2024
…hings. (#2701) * Removes logging each lua function called on the dm side of things. (#83483) ## About The Pull Request As the title says. This should significantly improve the performance of running lua scripts. ## Why It's Good For The Game There is a lot of performance overhead in logging each individual function called by a lua script as can be seen in the following screenshot: This is a test done on a local server where I run the `zombie_controller.lua` script that can be found on the auxlua-cookbook repository with a lot of AI zombies spawned in.   Logging these calls is not necessary as it doesn't provide any real information to anyone looking for bad actors. Lua scripts are already logged when ran and they can be examined to spot if the script being run is done so in bad faith. --------- Co-authored-by: Watermelon914 <[email protected]> * Removes logging each lua function called on the dm side of things. --------- Co-authored-by: Watermelon914 <[email protected]> Co-authored-by: Watermelon914 <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1766
Original PR: tgstation/tgstation#82259
About The Pull Request
See title
I left the item in and removed the antagonist checks from it just in case an admin wants to fuck around with it, but I can delete that too if preferred.
Why It's Good For The Game
This is both our least interesting and least impactful objective.
Turning into a (nerfed) space dragon sort of looks cool maybe the first time you do it and then after that it isn't. It is sort of disappointing to see it pop up in the uplink, in my experience.
This Space Dragon generally speaking isn't going to cause significant death or destruction except on lowpop (where a traitor can just do that anyway) or if they play in the cheesiest possible manner, it simply isn't that dangerous by itself.
It is also simply less versatile than just being a traitor with a lot of TC, something you already are when you get it.
Turning into a big animal also just doesn't feel much like something a traitor should be doing, that's a changeling or possibly wizard sort of objective.
It also sort of cheapens "real" space dragons by making them show up this way.
Finally; I just don't like it.
We have enough final objectives now that we don't need to keep this one just to fill the pool, in my opinion.
Changelog
🆑 Jacquerel
balance: Traitors can no longer turn themselves into dragons.
/:cl: