Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Actually Caches The BYOND Installation in CI (#82364) #2724

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1788

ORIGINAL PR: tgstation/tgstation#82364

About The Pull Request

Fun fact, nothing ever hashbanged this, so we've been using the same weeks-old cache which has been necessitating that we use the same old versions of BYOND until someone cleaned the cache. Let's tie to dependencies.sh like everything else (which we already did in #78307 (5e1c8bdebd610d82c4a9f7254342e7f299db0e19)) so we don't have to keep wasting time in CI compilations having to reinstall the needed BYOND version from scratch (and have caches date and auto-clear themselves when outdated)

the advantage is that we spend less time downloading/installing BYOND in CI runs and can actually run CI

…#1788)

Actually Caches The BYOND Installation in CI (#82364)

## About The Pull Request

Fun fact, nothing ever hashbanged this, so we've been using the same
weeks-old cache which has been necessitating that we use the same old
versions of BYOND until someone cleaned the cache. Let's tie to
`dependencies.sh` like everything else (which we already did in #78307
(5e1c8bdebd610d82c4a9f7254342e7f299db0e19)) so we don't have to keep
wasting time in CI compilations having to reinstall the needed BYOND
version from scratch (and have caches date and auto-clear themselves
when outdated)

the advantage is that we spend less time downloading/installing BYOND in
CI runs and can actually run CI

Co-authored-by: san7890 <[email protected]>
@mogeoko mogeoko merged commit f3bb233 into master Apr 3, 2024
24 checks passed
@mogeoko mogeoko deleted the upstream-mirror-1788 branch April 3, 2024 19:22
Iajret pushed a commit that referenced this pull request May 29, 2024
* Log trauma gain and loss (#83519)

* Log trauma gain and loss

---------

Co-authored-by: Time-Green <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
ReezeBL pushed a commit that referenced this pull request May 31, 2024
* Log trauma gain and loss (#83519)

* Log trauma gain and loss

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: Time-Green <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants