Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Prevents npcs from making progress bars #2737

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1797
Original PR: tgstation/tgstation#82413

About The Pull Request

A lot of lavaland mobs constantly make progress bars. Discovered this while working on another PR.

image

Put a breakpoint in progressbar/New to see what I mean.

Why It's Good For The Game

They can't even see them. Why are we making these? In case someone swaps in? That seems a bit too rare to justify this

Changelog

N/A literally nothing player facing

* Prevents npcs from making progress bars (#82413)

## About The Pull Request
A lot of lavaland mobs constantly make progress bars. Discovered this
while working on another PR.


![image](https://github.com/tgstation/tgstation/assets/42397676/2fc57cff-7e7e-46ea-8956-83c4ba44c69b)

Put a breakpoint in progressbar/New to see what I mean.
## Why It's Good For The Game
They can't even see them. Why are we making these? In case someone swaps
in? That seems a bit too rare to justify this
## Changelog
N/A literally nothing player facing

* Prevents npcs from making progress bars

---------

Co-authored-by: Jeremiah <[email protected]>
Co-authored-by: Bloop <[email protected]>
@Iajret Iajret merged commit 1b7ea84 into master Apr 4, 2024
26 checks passed
@Iajret Iajret deleted the upstream-mirror-1797 branch April 4, 2024 17:11
Iajret pushed a commit that referenced this pull request May 29, 2024
* Fix tips for metal foam. (#83532)

## About The Pull Request
### Old: 

![image](https://github.com/tgstation/tgstation/assets/96586172/554f4470-95d7-420d-9333-cef49c5af1b9)
### New:

![image](https://github.com/tgstation/tgstation/assets/96586172/865f40a7-7502-435f-a2e0-dc7a7cef851a)

closes tgstation/tgstation#83526
## Why It's Good For The Game
false tips are bad, let's make learning the game easier by sharing game
mechanics via descriptions.
## Changelog
:cl: grungussus
fix: fixed metal foam plating description and add more user friendly
explanation on how to replace tiling.
/:cl:

* Fix tips for metal foam.

---------

Co-authored-by: Sadboysuss <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants