[MIRROR] [Modular] Adds EMP effects for a few implants that were missing them #2745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1733) * emp interactions * fixes a typo * another typo :/ * consistency --------- Co-authored-by: NotDhu <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Apr 5, 2024
Iajret
pushed a commit
that referenced
this pull request
May 30, 2024
* Halves volume of Gravity Generator (#83553) ## About The Pull Request Halves the volume of sound produced by the gravity generator. This is done code-side and no change is made to the sound files. Apparently my tasteful composition of retro futuristic jetsons optimism juxtaposed with an underlying commentary on the costs associated with said optimistic attitude(see #83517) was lost on the end users of the /tg/station project. It has never been as clear to me that my HUGE FUCKING BRAIN with IQ of more than yours is wasted on the /tg/station project. Yet, my immense intellect is rivaled only by my nigh saintly mercy, and thus i have deigned to give you this one line pr. This is untested code. ## Why It's Good For The Game People who claim to play the game report that the gravity generator is still too loud. ## Changelog :cl: sound: The volume of the gravity generator has been halved /:cl: * Halves volume of Gravity Generator --------- Co-authored-by: Capsandi <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#1733
About The Pull Request
This adds EMP interactions for some of our newer implants that didn't have any EMP effects prior. I'll probably add more effects for the shell launcher and razorwire at a later date, but for now it's just the two new head implants - the binyat and the qani-laaca.
Qani-Laaca Sensory Computer:
EMPs cause this implant to malfunction, resulting in a sensory overload for the user as too much neural input is processed at once; stunning them for a few seconds and causing them to vomit up a /lot/ of blood.
Binyat Wireless Hacking Implant:
EMPs cause this implant to overheat 5x the normal amount, causing the user to combust in the process.
How This Contributes To The Nova Sector Roleplay Experience
EMPs have always been the intended means to counter combat implants and it always struck me as odd that a lot of our implants have no EMP interactions. This PR aims to fix that and gives a few of our implants unique and thematically appropriate EMP effects.
Proof of Testing
Video previews below.
Qani-Laaca:
stuntrim2.mp4
Binyat:
firetrim2.mp4
Changelog
🆑 SchizophrenicFelinid
balance: Added EMP interactions for Qani-Laaca and Binyat implants.
/:cl: