[MIRROR] Adds more fake Syndicate clothing to the loadout list, fixes and balances the existing ones #2747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nces the existing ones (#1560) * initial * a word * a line * cheap > stripped * review * review * oop
AnywayFarus
added a commit
that referenced
this pull request
Apr 5, 2024
Iajret
pushed a commit
that referenced
this pull request
May 30, 2024
* Deadens shuttle launching and docking to an extent (#83447) ## About The Pull Request Someone forgot to normalize their audio. Greatly deaden 'hyperspace_begin' and 'hyperspace_end' hyperspace_progress has been deaden to a lesser extent. Tested. ## Why It's Good For The Game You hear all of this every time you join the game late, not a good first impression. ## Changelog :cl: sound: Shuttle docking and undocking is quieter now /:cl: * Deadens shuttle launching and docking to an extent --------- Co-authored-by: Capsandi <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#1560
About The Pull Request
The tacticool clothing set is a series, these new ported clothing aren't part of that series. So I fixed that, and added the rest of the clothing that the port neglected. I also updated the armour, there's no reason for these items to have less armour than a jumpsuit. There's also a slight amount of code cleanup, subtypes don't need to have code repeated that their parent already carries.
Oh and they display properly on taurs, since everyone always forgets to remove the crop-code from skirt versions.
How This Contributes To The Nova Sector Roleplay Experience
This port NovaSector/NovaSector#1264 only did half the job. In this PR I add the items appropriately.
Proof of Testing
dreamseeker_a8OlhDIMg8.mp4
Changelog
🆑 honkpocket
add: Adds all versions of the Syndie clothing as fake, loadout-able gear instead of just the Overalls
balance: Fake Syndie clothing now isn't completely armorless, it has the same armor as jumpsuits
fix: The fake Syndie clothing display properly on Taur characters
/:cl: