Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] re-adds list of components for admins to remove #2757

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1829
Original PR: tgstation/tgstation#82461

About The Pull Request

The list of components on a mob when admins try to remove one didn't actually show them, now it does.
image

Why It's Good For The Game

Messing with components/elements on mobs are such a pain, in this case was broken entirely.
admin-toolings

Changelog

🆑 JohnFulpWillard
admin: Removing components button now lists components to remove
/:cl:

* re-adds list of components for admins to remove (#82461)

## About The Pull Request

The list of components on a mob when admins try to remove one didn't
actually show them, now it does.

![image](https://github.com/tgstation/tgstation/assets/53777086/a6102c3a-df30-4e9c-b7fd-29a4d8ddaa89)

## Why It's Good For The Game

Messing with components/elements on mobs are such a pain, in this case
was broken entirely.

![admin-toolings](https://github.com/tgstation/tgstation/assets/53777086/3d190c66-34e4-4424-824b-37f95e88b003)

## Changelog

:cl:
admin: Removing components button now lists components to remove
/:cl:

* re-adds list of components for admins to remove

---------

Co-authored-by: John Willard <[email protected]>
@Iajret Iajret merged commit 098e5ee into master Apr 6, 2024
26 checks passed
@Iajret Iajret deleted the upstream-mirror-1829 branch April 6, 2024 11:27
AnywayFarus added a commit that referenced this pull request Apr 6, 2024
Iajret pushed a commit that referenced this pull request Jun 21, 2024
* Telecomms Specialist

Adds a new lightweight role to engineering, the Telecomms Specialist! Monitor and repair telecomms when needed, watch out for suspicious activity on the network, and report to both engineering and security.

* Removed security comms

And changed alt job titesl

* minor issues fixed

* Update

Added some basic-edited uniforms, changed alternate job titles again.

* oopsie

forgot a comma

* jacket

gives them a jacket, it's cold in telecomms' machine room

* alt titles and icons

* upped to 2 slots

* added a tcomm specific jacket

* added span_doyourjobidiot

A warning/friendly reminder to abide by server rules.

* back down to 1

* added crew monitor bit and adjusted jumpsuit/skirt variables and desc

* mapping spawnpoint

* landmarks and spawn area

* fixed

* Changes as requested

* added another area

maybe this will get it to pass map integration

* another try

does a fourth area even work

* removed unneeded spawn area

since we're gonna have to manually place it anyway...

* added landmarks for nova maps via lt3

* Apply suggestions from code review

* Apply suggestions from code review

---------

Co-authored-by: Zergspower <[email protected]>
Co-authored-by: Bloop <[email protected]>
Iajret added a commit that referenced this pull request Jun 22, 2024
* [SEMI-MODULAR] Telecomms Specialist (#2757)

* Telecomms Specialist

Adds a new lightweight role to engineering, the Telecomms Specialist! Monitor and repair telecomms when needed, watch out for suspicious activity on the network, and report to both engineering and security.

* Removed security comms

And changed alt job titesl

* minor issues fixed

* Update

Added some basic-edited uniforms, changed alternate job titles again.

* oopsie

forgot a comma

* jacket

gives them a jacket, it's cold in telecomms' machine room

* alt titles and icons

* upped to 2 slots

* added a tcomm specific jacket

* added span_doyourjobidiot

A warning/friendly reminder to abide by server rules.

* back down to 1

* added crew monitor bit and adjusted jumpsuit/skirt variables and desc

* mapping spawnpoint

* landmarks and spawn area

* fixed

* Changes as requested

* added another area

maybe this will get it to pass map integration

* another try

does a fourth area even work

* removed unneeded spawn area

since we're gonna have to manually place it anyway...

* added landmarks for nova maps via lt3

* Apply suggestions from code review

* Apply suggestions from code review

---------

Co-authored-by: Zergspower <[email protected]>
Co-authored-by: Bloop <[email protected]>

* tcomm admin added

---------

Co-authored-by: SciDragon <[email protected]>
Co-authored-by: Zergspower <[email protected]>
Co-authored-by: Bloop <[email protected]>
Co-authored-by: Iajret <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants