[MIRROR] Fix captive xeno roundend report runtime #2764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix captive xeno roundend report runtime (#82490) ## About The Pull Request `check_captivity` accepts a mob, not a mind  Which leads me to believe this always returned `null` and always failed. But checking further and this proc does not return a truthy or falsy value at all, meaning even if this runtime didn't happen, it still wouldn't function correctly. So I made it check for `CAPTIVE_XENO_PASS`. ## Changelog :cl: Melbert fix: Captive Xeno end round report should make a tad more sense /:cl: * Fix captive xeno roundend report runtime --------- Co-authored-by: MrMelbert <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Apr 7, 2024
Iajret
pushed a commit
that referenced
this pull request
Jun 1, 2024
* Gives the Lawyer a pet goldfish (#83461) ## About The Pull Request The law office now has a pet, a goldfish named McGill. ## Why It's Good For The Game I've wanted to integrate aquariums and fishes in general into more roundstart, since it currently either requires being built and/or ordered, and thought giving it as a pet to the Law Office would be pretty cool since the law office doesn't have one and deserves one, and also just a silly reference. ## Changelog :cl: add: The Law office now has a pet goldfish. /:cl: * Gives the Lawyer a pet goldfish * Adds to our maps --------- Co-authored-by: John Willard <[email protected]> Co-authored-by: NovaBot13 <[email protected]> Co-authored-by: Mal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1844
Original PR: tgstation/tgstation#82490
About The Pull Request
check_captivityaccepts a mob, not a mindWhich leads me to believe this always returned
nulland always failed.But checking further and this proc does not return a truthy or falsy value at all, meaning even if this runtime didn't happen, it still wouldn't function correctly. So I made it check for
CAPTIVE_XENO_PASS.Changelog
🆑 Melbert
fix: Captive Xeno end round report should make a tad more sense
/:cl: