Шортики СБ #2774
Closed
Шортики СБ #2774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
closed this
Iajret
pushed a commit
that referenced
this pull request
Jun 1, 2024
* Fixes runtime with serializing photo metadata (#83562) ## About The Pull Request So while working on an entirely unrelated thing, I noticed runtimes appearing in my logs after taking a picture. Specifically a bad index runtime for the 77th line here: https://github.com/tgstation/tgstation/blob/2f6920105e097479ae1f2fdf2823e2e8fdc59f3b/code/modules/photography/_pictures.dm#L66-L78 And the 199th line here: https://github.com/tgstation/tgstation/blob/2f6920105e097479ae1f2fdf2823e2e8fdc59f3b/code/datums/datum.dm#L193-L200 This seemed to be caused by the fact `serialize_list(...)` is called with a null `semvers` parameter, which then causes it to try to add to a null list. I asked about this in code general on the main discord, and got told just putting an empty list in when `serialize_list(...)` is called should be fine. This resolves the runtime. ## Why It's Good For The Game Better to not have two runtimes added to the logs whenever someone takes a picture. Fixes #80514. * Fixes runtime with serializing photo metadata --------- Co-authored-by: _0Steven <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
AnywayFarus
pushed a commit
that referenced
this pull request
Jun 2, 2024
* Fixes runtime with serializing photo metadata (#83562) ## About The Pull Request So while working on an entirely unrelated thing, I noticed runtimes appearing in my logs after taking a picture. Specifically a bad index runtime for the 77th line here: https://github.com/tgstation/tgstation/blob/2f6920105e097479ae1f2fdf2823e2e8fdc59f3b/code/modules/photography/_pictures.dm#L66-L78 And the 199th line here: https://github.com/tgstation/tgstation/blob/2f6920105e097479ae1f2fdf2823e2e8fdc59f3b/code/datums/datum.dm#L193-L200 This seemed to be caused by the fact `serialize_list(...)` is called with a null `semvers` parameter, which then causes it to try to add to a null list. I asked about this in code general on the main discord, and got told just putting an empty list in when `serialize_list(...)` is called should be fine. This resolves the runtime. ## Why It's Good For The Game Better to not have two runtimes added to the logs whenever someone takes a picture. Fixes #80514. * Fixes runtime with serializing photo metadata --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: _0Steven <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
О Pull Request
Хвостам жарко в штанах. Нужны шортики!
Как это может улучшит/повлиять на игровой процесс/ролевую игру
Придаст атмосферы.
Доказательства тестирования
Скриншоты/Видео
Changelog
🆑
add: Sec shorts for hot officers
/:cl: