Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Reverts reversion: tgui will 516 or else #2775

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1863
Original PR: tgstation/tgstation#82527

About The Pull Request

Context: #82522

Apparently you cant just stuff the byond helper functions into an external js file, but if you do, byond won't even let you know its a problem until the servers crash and you have to run bin/clean just to unbork your entire repo

This reimplements the changes from #82473 without:

  • moving the byond helper functions externally
  • causing a tooltip render issue in panel

Why It's Good For The Game

516 prep (again this time)

* Reverts reversion: tgui will 516 or else (#82527)

## About The Pull Request
Context: #82522

Apparently you cant just stuff the byond helper functions into an
external js file, but if you do, byond won't even let you know its a
problem until the servers crash and you have to run `bin/clean` just to
unbork your entire repo

This reimplements the changes from #82473 without:
- moving the byond helper functions externally
- causing a tooltip render issue in panel

## Why It's Good For The Game
516 prep (again this time)

* Reverts reversion: tgui will 516 or else

---------

Co-authored-by: Jeremiah <[email protected]>
@Iajret Iajret merged commit 68bf272 into master Apr 8, 2024
24 checks passed
@Iajret Iajret deleted the upstream-mirror-1863 branch April 8, 2024 20:42
Iajret pushed a commit that referenced this pull request Jun 1, 2024
* print 5 cable coils instead of 1 in lathes (#83601)

## About The Pull Request
What the title says.
## Why It's Good For The Game
It is incredibly tedious to get a large amount of cables from lathes,
considering you need a lot most of the time (especially in engineering),
it should be printing way more than one piece of cable.
## Changelog
:cl: grungussuss
qol: lathes will now print cables coils in packs of 5
/:cl:

* print 5 cable coils instead of 1 in lathes

---------

Co-authored-by: grungussuss <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
AnywayFarus pushed a commit that referenced this pull request Jun 2, 2024
* print 5 cable coils instead of 1 in lathes (#83601)

## About The Pull Request
What the title says.
## Why It's Good For The Game
It is incredibly tedious to get a large amount of cables from lathes,
considering you need a lot most of the time (especially in engineering),
it should be printing way more than one piece of cable.
## Changelog
:cl: grungussuss
qol: lathes will now print cables coils in packs of 5
/:cl:

* print 5 cable coils instead of 1 in lathes

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: grungussuss <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants