[MIRROR] Fixes the color matrix editor #2777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes the color matrix editor (#82478) ## About The Pull Request It was sending back stringified numbers as inputs. This came from a typescript cleanup pr from sync (#82000) and was ultimately caused by a... I think misunderstanding of how the color list works (#67967) ## Why It's Good For The Game Works like a charm now, which is good cause I use it a lot ## Changelog :cl: fix: The color matrix editor now works properly again /:cl: * Fixes the color matrix editor --------- Co-authored-by: LemonInTheDark <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Apr 8, 2024
Iajret
pushed a commit
that referenced
this pull request
Jun 1, 2024
…s containing living entities. (#2777) * Remove a bunch of unnecessary periods from photo descriptions containing living entities. (#83564) ## About The Pull Request Looking at a picture I noticed the description was a bit off, so I did some testing:  Lo and behold, wow it really does just slap periods on everywhere huh? So I just went through the code for getting mob photo descriptions and shuffled around where and when the periods are placed til it no longer did that:  Also replaced a single letter variable while I was at it. ### EDIT: Also added newlines between them, for good measure.  ## Why It's Good For The Game Think it's better for there to not be excess periods. .. ### EDIT: The added newlines also make it, well, more readable. ## Changelog :cl: spellcheck: Photo descriptions containing living entities no longer have a pile of unnecessary periods. .. Which they used to have between describing different entities. .. Also removed that additional space they had too sometimes.. qol: Photo descriptions containing living entities have these sub-descriptions split into newlines for ease of reading. /:cl: * Remove a bunch of unnecessary periods from photo descriptions containing living entities. --------- Co-authored-by: _0Steven <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
AnywayFarus
pushed a commit
that referenced
this pull request
Jun 2, 2024
…s containing living entities. (#2777) (#3580) * Remove a bunch of unnecessary periods from photo descriptions containing living entities. (#83564) ## About The Pull Request Looking at a picture I noticed the description was a bit off, so I did some testing:  Lo and behold, wow it really does just slap periods on everywhere huh? So I just went through the code for getting mob photo descriptions and shuffled around where and when the periods are placed til it no longer did that:  Also replaced a single letter variable while I was at it. ### EDIT: Also added newlines between them, for good measure.  ## Why It's Good For The Game Think it's better for there to not be excess periods. .. ### EDIT: The added newlines also make it, well, more readable. ## Changelog :cl: spellcheck: Photo descriptions containing living entities no longer have a pile of unnecessary periods. .. Which they used to have between describing different entities. .. Also removed that additional space they had too sometimes.. qol: Photo descriptions containing living entities have these sub-descriptions split into newlines for ease of reading. /:cl: * Remove a bunch of unnecessary periods from photo descriptions containing living entities. --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: _0Steven <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1856
Original PR: tgstation/tgstation#82478
About The Pull Request
It was sending back stringified numbers as inputs. This came from a typescript cleanup pr from sync (#82000) and was ultimately caused by a... I think misunderstanding of how the color list works (#67967)
Why It's Good For The Game
Works like a charm now, which is good cause I use it a lot
Changelog
🆑 LemonInTheDark
fix: The color matrix editor now works properly again
/:cl: