Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Maint Mania dust runtime fix #2779

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1855
Original PR: tgstation/tgstation#82487

About The Pull Request

This removes some dust from a space tile that was throwing stack_traces every time the Maint Mania map was loaded up.

Why It's Good For The Game

Less clutter while looking for an entirely unrelated runtime regarding deathmatch.

Changelog

🆑 Rhials
fix: Sweeps a tile of dust off of the Maint Mania deathmatch map, which was causing errors.
/:cl:

* Maint Mania dust runtime fix (#82487)

## About The Pull Request

This removes some dust from a space tile that was throwing stack_traces
every time the Maint Mania map was loaded up.
## Why It's Good For The Game

Less clutter while looking for an entirely unrelated runtime regarding
deathmatch.
## Changelog
:cl: Rhials
fix: Sweeps a tile of dust off of the Maint Mania deathmatch map, which
was causing errors.
/:cl:

* Maint Mania dust runtime fix

---------

Co-authored-by: Rhials <[email protected]>
@Iajret Iajret merged commit 86d8fa1 into master Apr 8, 2024
26 checks passed
@Iajret Iajret deleted the upstream-mirror-1855 branch April 8, 2024 22:12
AnywayFarus added a commit that referenced this pull request Apr 8, 2024
Iajret pushed a commit that referenced this pull request Jun 1, 2024
…e wrenched + add contextual helpers to help visualize its interactions (#2779)

* Allows the fermenting (wooden) barrel to be emptied and to be wrenched + add contextual helpers to help visualize its interactions (#83491)

## About The Pull Request
Wooden barrels can now be wrenched down to be anchored, which should
make them a lot more convenient if you want to avoid people constantly
pushing them around.

They can also now be emptied by right-clicking with an empty hand, to
help with accidents that do unfortunately happen, like when you add an
additional fruit that you didn't mean to add to the barrel on accident.

I also figured I'd improve its readability by giving it contextual
helpers, and I'm quite pleased with the results.

## Why It's Good For The Game
More QoL functionalities is always good. More controls visibility is
just better for accessibility.

## Changelog

:cl: GoldenAlpharex
qol: Fermenting (wooden) barrels can now be emptied when opened by
right-clicking with an empty hand!
qol: Fermenting (wooden) barrels can now be anchored/unanchored using
wrenches!
qol: Fermenting (wooden) barrels now have contextual helpers, to show
what you need to do at a glance to interact with them.
code: Documented a few of the fermenting barrel's variables.
/:cl:

* Allows the fermenting (wooden) barrel to be emptied and to be wrenched + add contextual helpers to help visualize its interactions

---------

Co-authored-by: GoldenAlpharex <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
AnywayFarus pushed a commit that referenced this pull request Jun 2, 2024
…e wrenched + add contextual helpers to help visualize its interactions (#2779) (#3582)

* Allows the fermenting (wooden) barrel to be emptied and to be wrenched + add contextual helpers to help visualize its interactions (#83491)

## About The Pull Request
Wooden barrels can now be wrenched down to be anchored, which should
make them a lot more convenient if you want to avoid people constantly
pushing them around.

They can also now be emptied by right-clicking with an empty hand, to
help with accidents that do unfortunately happen, like when you add an
additional fruit that you didn't mean to add to the barrel on accident.

I also figured I'd improve its readability by giving it contextual
helpers, and I'm quite pleased with the results.

## Why It's Good For The Game
More QoL functionalities is always good. More controls visibility is
just better for accessibility.

## Changelog

:cl: GoldenAlpharex
qol: Fermenting (wooden) barrels can now be emptied when opened by
right-clicking with an empty hand!
qol: Fermenting (wooden) barrels can now be anchored/unanchored using
wrenches!
qol: Fermenting (wooden) barrels now have contextual helpers, to show
what you need to do at a glance to interact with them.
code: Documented a few of the fermenting barrel's variables.
/:cl:

* Allows the fermenting (wooden) barrel to be emptied and to be wrenched + add contextual helpers to help visualize its interactions

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: GoldenAlpharex <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants