Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Very small atom examine tweaks #2784

Merged
merged 1 commit into from
Apr 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions code/__DEFINES/dcs/signals/signals_atom/signals_atom_main.dm
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,9 @@
///from base of atom/get_examine_name(): (/mob, list/overrides)
#define COMSIG_ATOM_GET_EXAMINE_NAME "atom_examine_name"
//Positions for overrides list
#define EXAMINE_POSITION_ARTICLE (1<<0)
#define EXAMINE_POSITION_BEFORE (1<<1)
//End positions
#define COMPONENT_EXNAME_CHANGED (1<<0)
#define EXAMINE_POSITION_ARTICLE 1
#define EXAMINE_POSITION_BEFORE 2
#define EXAMINE_POSITION_NAME 3
///from base of atom/examine(): (/mob, list/examine_text, can_see_inside)
#define COMSIG_ATOM_REAGENT_EXAMINE "atom_reagent_examine"
/// Stop the generic reagent examine text
Expand Down
7 changes: 2 additions & 5 deletions code/datums/elements/decals/blood.dm
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,7 @@
pic = blood_splatter
return TRUE

/datum/element/decal/blood/proc/get_examine_name(datum/source, mob/user, list/override)
/datum/element/decal/blood/proc/get_examine_name(atom/source, mob/user, list/override)
SIGNAL_HANDLER

var/atom/A = source
override[EXAMINE_POSITION_ARTICLE] = A.gender == PLURAL? "some" : "a"
override[EXAMINE_POSITION_BEFORE] = " blood-stained "
return COMPONENT_EXNAME_CHANGED
override[EXAMINE_POSITION_BEFORE] = "blood-stained"
17 changes: 10 additions & 7 deletions code/game/atom/atom_examine.dm
Original file line number Diff line number Diff line change
Expand Up @@ -83,13 +83,16 @@
* [COMSIG_ATOM_GET_EXAMINE_NAME] signal
*/
/atom/proc/get_examine_name(mob/user)
. = "\a <b>[src]</b>"
var/list/override = list(gender == PLURAL ? "some" : "a", " ", "[name]")
if(article)
. = "[article] <b>[src]</b>"
override[EXAMINE_POSITION_ARTICLE] = article
if(SEND_SIGNAL(src, COMSIG_ATOM_GET_EXAMINE_NAME, user, override) & COMPONENT_EXNAME_CHANGED)
. = override.Join("")
var/list/override = list(article, null, "<b>[name]</b>")
SEND_SIGNAL(src, COMSIG_ATOM_GET_EXAMINE_NAME, user, override)

if(!isnull(override[EXAMINE_POSITION_ARTICLE]))
override -= null // IF there is no "before", don't try to join it
return jointext(override, " ")
if(!isnull(override[EXAMINE_POSITION_BEFORE]))
override -= null // There is no article, don't try to join it
return "\a [jointext(override, " ")]"
return "\a <b>[src]</b>"

///Generate the full examine string of this atom (including icon for goonchat)
/atom/proc/get_examine_string(mob/user, thats = FALSE)
Expand Down
8 changes: 4 additions & 4 deletions code/game/objects/structures/window.dm
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,7 @@ MAPPING_DIRECTIONAL_HELPERS(/obj/structure/window/reinforced/tinted/frosted/spaw
anchored = FALSE

/obj/structure/window/reinforced/plasma/fulltile
icon = 'icons/obj/smooth_structures/rplasma_window.dmi' //ICON OVERRIDEN IN SKYRAT AESTHETICS - SEE MODULE
icon = 'icons/obj/smooth_structures/rplasma_window.dmi' // NOVA EDIT ICON OVERRIDDEN IN AESTHETICS
icon_state = "rplasma_window-0"
base_icon_state = "rplasma_window"
state = RWINDOW_SECURE
Expand All @@ -715,8 +715,8 @@ MAPPING_DIRECTIONAL_HELPERS(/obj/structure/window/reinforced/tinted/frosted/spaw

/obj/structure/window/reinforced/fulltile
name = "full tile reinforced window"
desc = "A full tile reinforced window"
icon = 'icons/obj/smooth_structures/reinforced_window.dmi' //ICON OVERRIDDEN IN SKYRAT AESTHETICS - SEE MODULE
desc = "A full tile window that is reinforced with metal rods."
icon = 'icons/obj/smooth_structures/reinforced_window.dmi' // NOVA EDIT ICON OVERRIDDEN IN AESTHETICS
icon_state = "reinforced_window-0"
base_icon_state = "reinforced_window"
max_integrity = 150
Expand All @@ -739,7 +739,7 @@ MAPPING_DIRECTIONAL_HELPERS(/obj/structure/window/reinforced/tinted/frosted/spaw
state = WINDOW_OUT_OF_FRAME

/obj/structure/window/reinforced/tinted/fulltile
icon = 'icons/obj/smooth_structures/tinted_window.dmi' //ICON OVERRIDEN IN SKYRAT AESTHETICS - SEE MODULE
icon = 'icons/obj/smooth_structures/tinted_window.dmi' // NOVA EDIT ICON OVERRIDDEN IN AESTHETICS
icon_state = "tinted_window-0"
base_icon_state = "tinted_window"
fulltile = TRUE
Expand Down
2 changes: 2 additions & 0 deletions code/modules/clothing/gloves/_gloves.dm
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
attack_verb_simple = list("challenge")
strip_delay = 20
equip_delay_other = 40
article = "a pair of"

// Path variable. If defined, will produced the type through interaction with wirecutters.
var/cut_type = null
/// Used for handling bloody gloves leaving behind bloodstains on objects. Will be decremented whenever a bloodstain is left behind, and be incremented when the gloves become bloody.
Expand Down
2 changes: 2 additions & 0 deletions code/modules/clothing/shoes/_shoes.dm
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
armor_type = /datum/armor/clothing_shoes
slowdown = SHOES_SLOWDOWN
strip_delay = 1 SECONDS
article = "a pair of"

var/offset = 0
var/equipped_before_drop = FALSE
///Whether these shoes have laces that can be tied/untied
Expand Down
2 changes: 1 addition & 1 deletion code/modules/mob/living/carbon/human/examine.dm
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@
. += "[t_He] [t_has] [gloves.get_examine_string(user)] on [t_his] hands."
else if(GET_ATOM_BLOOD_DNA_LENGTH(src))
if(num_hands)
. += span_warning("[t_He] [t_has] [num_hands > 1 ? "" : "a"] blood-stained hand[num_hands > 1 ? "s" : ""]!")
. += span_warning("[t_He] [t_has] [num_hands > 1 ? "" : "a "]blood-stained hand[num_hands > 1 ? "s" : ""]!")

//handcuffed?
if(handcuffed)
Expand Down
Loading