Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Adds Healthdoll to Basic Dexterous Mobs #2787

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1871
Original PR: tgstation/tgstation#82541

About The Pull Request

This PR adds a health doll to the hud used by basic and simple mobs to the dexterous basic mob HUD. I'd reckon the only reason it wasn't initially there in the first place is by mistake.

This also apparently adds the damage borders around the screen as the mob takes damage, which is a useful gauge for knowing when you're about to die.

image

Why It's Good For The Game

Basic QoL change to provide basic dexterous mobs with the same level of health info that we provide everything else.

Changelog

🆑 IndieanaJones
qol: Basic dexterous mobs now have a health doll and screen damage indication like other basic mobs.
/:cl:

* Adds Healthdoll to Basic Dexterous Mobs (#82541)

## About The Pull Request

This PR adds a health doll to the hud used by basic and simple mobs to
the dexterous basic mob HUD. I'd reckon the only reason it wasn't
initially there in the first place is by mistake.

This also apparently adds the damage borders around the screen as the
mob takes damage, which is a useful gauge for knowing when you're about
to die.


![image](https://github.com/tgstation/tgstation/assets/47086570/d5c45f32-2326-4c65-bf67-77b10c0c153e)

## Why It's Good For The Game

Basic QoL change to provide basic dexterous mobs with the same level of
health info that we provide everything else.

## Changelog
:cl:
qol: Basic dexterous mobs now have a health doll and screen damage
indication like other basic mobs.
/:cl:

* Adds Healthdoll to Basic Dexterous Mobs

---------

Co-authored-by: IndieanaJones <[email protected]>
@mogeoko mogeoko merged commit 164d537 into master Apr 10, 2024
26 checks passed
@mogeoko mogeoko deleted the upstream-mirror-1871 branch April 10, 2024 16:52
AnywayFarus added a commit that referenced this pull request Apr 10, 2024
Iajret pushed a commit that referenced this pull request Jun 1, 2024
* fix: allow giant spiders aggressively grab again (#83531)

## About The Pull Request

Remove check that restricted non-carbon mobs from upgrading grab, using
`max_grab` instead which exists for this purpose
All mobs now have `max_grab` set to `GRAB_PASSIVE` by default, overrided
where required.
Giant spiders can now agressively grab, which makes `ambush` spider
playable again (i hope).

closes #83485

## Why It's Good For The Game

Ambush spider works as intended, as it has `STRONG_GRABBER` trait, but
effectively it didn't work, as spiders couldn't grab agressively.

## Changelog

:cl:
fix: ambush spider (should instantly agressive grab) and other giant
spiders can now agressively grab
/:cl:

* fix: allow giant spiders aggressively grab again

---------

Co-authored-by: Gaxeer <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
AnywayFarus pushed a commit that referenced this pull request Jun 2, 2024
)

* fix: allow giant spiders aggressively grab again (#83531)

## About The Pull Request

Remove check that restricted non-carbon mobs from upgrading grab, using
`max_grab` instead which exists for this purpose
All mobs now have `max_grab` set to `GRAB_PASSIVE` by default, overrided
where required.
Giant spiders can now agressively grab, which makes `ambush` spider
playable again (i hope).

closes #83485

## Why It's Good For The Game

Ambush spider works as intended, as it has `STRONG_GRABBER` trait, but
effectively it didn't work, as spiders couldn't grab agressively.

## Changelog

:cl:
fix: ambush spider (should instantly agressive grab) and other giant
spiders can now agressively grab
/:cl:

* fix: allow giant spiders aggressively grab again

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: Gaxeer <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants