Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Adds anosmia quirk #2790

Merged
merged 1 commit into from
Apr 9, 2024
Merged

[MIRROR] Adds anosmia quirk #2790

merged 1 commit into from
Apr 9, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1890
Original PR: tgstation/tgstation#82206

About The Pull Request

Adds anosmia quirk. Anosmia, also known as smell blindness, is the loss of the ability to detect one or more smells.

I tried to find all smells action and (most likely) update all of them, unfortunately I can't change descriptions for this quirk.

Why It's Good For The Game

Some characters will be able to not feel smells
That affect:

  • Gases feelings and alerts (CO2, Plasma, miasm) - you don't feel them
  • Bakery and cooking
  • Changeling ability to feel other changelings by smell
  • Some unimportant spans

image

image

Changelog

🆑 NeonNik2245
add: Adds anosmia quirk
/:cl:

* Adds anosmia quirk (#82206)

## About The Pull Request

Adds anosmia quirk. Anosmia, also known as smell blindness, is the loss
of the ability to detect one or more smells.

I tried to find all smells action and (most likely) update all of them,
unfortunately I can't change descriptions for this quirk.

## Why It's Good For The Game

Some characters will be able to not feel smells
That affect:
* Gases feelings and alerts (CO2, Plasma, miasm) - you don't feel them
* Bakery and cooking
* Changeling ability to feel other changelings by smell
* Some unimportant spans

* Adds anosmia quirk

---------

Co-authored-by: NeonNik2245 <[email protected]>
@Iajret Iajret merged commit 51a9e7b into master Apr 9, 2024
26 checks passed
AnywayFarus added a commit that referenced this pull request Apr 9, 2024
@Iajret Iajret deleted the upstream-mirror-1890 branch April 9, 2024 16:50
Iajret pushed a commit that referenced this pull request Jun 1, 2024
* Minor code clean-up for Cryo (#83477)

## About The Pull Request
- Converts `attackby()` to `item_interaction_with()` 
- Prevents abstract/hologram beaker interactions with Cryo
- Cryo respects `NO_DEBRIS_AFTER_DECONSTRUCTION` by properly removing
the mobs visual contents flag & related traits inside
`handle_deconstruct()` instead of `on_deconstruction()`
- Uses `CHEMICAL_VOLUME_ROUNDING` define for rounding reagent volumes.

Everything else is just shuffling code around

## Changelog
:cl:
fix: Cryo tube respects `NO_DEBRIS_AFTER_DECONSTRUCTION` for the
occupants visual contents flags & traits & won't allow hologram/abstract
item interactions
code: Cryo has improved attack chain & uses defines for reagent volume
rounding
/:cl:

* Minor code clean-up for Cryo

---------

Co-authored-by: SyncIt21 <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
AnywayFarus pushed a commit that referenced this pull request Jun 2, 2024
* Minor code clean-up for Cryo (#83477)

## About The Pull Request
- Converts `attackby()` to `item_interaction_with()` 
- Prevents abstract/hologram beaker interactions with Cryo
- Cryo respects `NO_DEBRIS_AFTER_DECONSTRUCTION` by properly removing
the mobs visual contents flag & related traits inside
`handle_deconstruct()` instead of `on_deconstruction()`
- Uses `CHEMICAL_VOLUME_ROUNDING` define for rounding reagent volumes.

Everything else is just shuffling code around

## Changelog
:cl:
fix: Cryo tube respects `NO_DEBRIS_AFTER_DECONSTRUCTION` for the
occupants visual contents flags & traits & won't allow hologram/abstract
item interactions
code: Cryo has improved attack chain & uses defines for reagent volume
rounding
/:cl:

* Minor code clean-up for Cryo

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: SyncIt21 <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants