Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fixes some grammar on vorpal scythe execute #2793

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1877
Original PR: tgstation/tgstation#82509

About The Pull Request

Easy PR on the tin, we were calling "the [src]" in a number of places on the vorpal scythe execute causing it to say "the the vorpal scythe"

Why It's Good For The Game

5 second grammar fix basically

Changelog

🆑 ArcaneMusic
fix: Vorpal Scythe execute messages now read correctly.
/:cl:

* Fixes some grammar on vorpal scythe execute (#82509)

## About The Pull Request

Easy PR on the tin, we were calling "the [src]" in a number of places on
the vorpal scythe execute causing it to say "the the vorpal scythe"

## Why It's Good For The Game

5 second grammar fix basically

## Changelog


:cl:
fix: Vorpal Scythe execute messages now read correctly.
/:cl:

* Fixes some grammar on vorpal scythe execute

---------

Co-authored-by: ArcaneMusic <[email protected]>
@mogeoko mogeoko merged commit ceb2105 into master Apr 10, 2024
26 checks passed
@mogeoko mogeoko deleted the upstream-mirror-1877 branch April 10, 2024 16:54
AnywayFarus added a commit that referenced this pull request Apr 10, 2024
Iajret pushed a commit that referenced this pull request Jun 1, 2024
* Biogen refactor + fixes [no gbp] (#83589)

## About The Pull Request
They were using a nested uselocalstate which I naively converted to
usestate

This gave it the treatment(tm) which means just simplifying it by not
creating a component which maps new items inside of itself

I also fixed the layout shift caused by buttons / pricing

![image](https://github.com/tgstation/tgstation/assets/42397676/f8f99d68-4d50-4d73-a266-020487e6764b)
## Why It's Good For The Game
Fixes #83571
## Changelog
:cl:
fix: Fixed the biogenerator's tabs
/:cl:

* Biogen refactor + fixes [no gbp]

---------

Co-authored-by: Jeremiah <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants