[MIRROR] Mech mob deletion fix #2797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Mech mob deletion fix (#82415) ## About The Pull Request If the occupant of a mech has their mob changed -- mutation, polymorph, admin fuckery -- or if a mob somehow enters a mech without becoming an occupant -- the above, or a chestburster in said mech pilot -- then they don't get added to the occupants, only the contents. All contents are hard-deleted if a mech is destroyed. This fixes that, and ejects any mobs inside mechs who are technically inside the mech but not an occupant. ## Why It's Good For The Game Fixes #82395 and any similar case ## Changelog Being inside a mech when it's destroyed should no longer delete you, even if you ended up in that mech in an odd way. :cl: Bisar fix: Mechs will no longer delete their living non-occupant contents when destroyed. /:cl: * Mech mob deletion fix --------- Co-authored-by: Joshua Kidder <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Apr 10, 2024
Iajret
pushed a commit
that referenced
this pull request
Jun 1, 2024
…s) to the new Adrenal Glands (#2797) * Patches exploit with (and pre-emptively bumps the usage costs) to the new Adrenal Glands (#83612) ## About The Pull Request 1. Because the reset timer was not done with `TIMER_UNIQUE|TIMER_OVERRIDE`, this meant that you could pop the ability, wait 19 seconds, and then pop it again. And now you had all the benefits of the ability without any of the downsides, because the timers would not reset and instead run simultaneously. I fixed this by both adding the timer flags and by preventing usage of the skill while you are under the effects of it. (Just in case.) 2. With permission from Jacquerel, I bumped the chemical cost and dna cost back up to similar numbers as before. I think the PR swung the hammer way too far in that direction (You don't make it more spammable while also making it better, you either do one or the other!) ## Changelog :cl: Melbert balance: Re-ups the cost of the new ling adrenal ability fix: Patches an exploit with new ling adrenal ability /:cl: * Patches exploit with (and pre-emptively bumps the usage costs) to the new Adrenal Glands --------- Co-authored-by: MrMelbert <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
AnywayFarus
pushed a commit
that referenced
this pull request
Jun 2, 2024
…s) to the new Adrenal Glands (#2797) (#3594) * Patches exploit with (and pre-emptively bumps the usage costs) to the new Adrenal Glands (#83612) ## About The Pull Request 1. Because the reset timer was not done with `TIMER_UNIQUE|TIMER_OVERRIDE`, this meant that you could pop the ability, wait 19 seconds, and then pop it again. And now you had all the benefits of the ability without any of the downsides, because the timers would not reset and instead run simultaneously. I fixed this by both adding the timer flags and by preventing usage of the skill while you are under the effects of it. (Just in case.) 2. With permission from Jacquerel, I bumped the chemical cost and dna cost back up to similar numbers as before. I think the PR swung the hammer way too far in that direction (You don't make it more spammable while also making it better, you either do one or the other!) ## Changelog :cl: Melbert balance: Re-ups the cost of the new ling adrenal ability fix: Patches an exploit with new ling adrenal ability /:cl: * Patches exploit with (and pre-emptively bumps the usage costs) to the new Adrenal Glands --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: MrMelbert <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1884
Original PR: tgstation/tgstation#82415
About The Pull Request
If the occupant of a mech has their mob changed -- mutation, polymorph, admin fuckery -- or if a mob somehow enters a mech without becoming an occupant -- the above, or a chestburster in said mech pilot -- then they don't get added to the occupants, only the contents. All contents are hard-deleted if a mech is destroyed. This fixes that, and ejects any mobs inside mechs who are technically inside the mech but not an occupant.
Why It's Good For The Game
Fixes #82395 and any similar case
Changelog
Being inside a mech when it's destroyed should no longer delete you, even if you ended up in that mech in an odd way.
🆑 Bisar
fix: Mechs will no longer delete their living non-occupant contents when destroyed.
/:cl: