[MIRROR] Post-round blob zombies no longer offer themselves to ghosts #2799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to ghosts (#1882) * [NO GBP] Post-round blob zombies no longer offer themselves to ghosts (#82542) ## About The Pull Request This should properly fix the post-blob-win audio/notif spam for real this time. I wanted to preserve the effect as much as possible, so they just don't poll for ghosts when the round is already over. ## Why It's Good For The Game Closes #80998 for real this time. ## Changelog :cl: Rhials fix: The tide of post-round blob zombies when a blob wins will no longer break the speakers in your headset. /:cl: * [NO GBP] Post-round blob zombies no longer offer themselves to ghosts --------- Co-authored-by: Rhials <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Apr 10, 2024
Iajret
pushed a commit
that referenced
this pull request
Jun 1, 2024
… as COMSIG_ATOM_DIR_CHANGE (#2799) * Fixes COMSIG_ATOM_POST_DIR_CHANGE having the same definition as COMSIG_ATOM_DIR_CHANGE (#83604) ## About The Pull Request Title. ## Why It's Good For The Game Turns out, signals having the same definition causes a lot of issues. ## Changelog :cl: fix: COMSIG_ATOM_POST_DIR_CHANGE is now a functional signal /:cl: * Fixes COMSIG_ATOM_POST_DIR_CHANGE having the same definition as COMSIG_ATOM_DIR_CHANGE --------- Co-authored-by: nikothedude <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
AnywayFarus
pushed a commit
that referenced
this pull request
Jun 2, 2024
… as COMSIG_ATOM_DIR_CHANGE (#2799) (#3601) * Fixes COMSIG_ATOM_POST_DIR_CHANGE having the same definition as COMSIG_ATOM_DIR_CHANGE (#83604) ## About The Pull Request Title. ## Why It's Good For The Game Turns out, signals having the same definition causes a lot of issues. ## Changelog :cl: fix: COMSIG_ATOM_POST_DIR_CHANGE is now a functional signal /:cl: * Fixes COMSIG_ATOM_POST_DIR_CHANGE having the same definition as COMSIG_ATOM_DIR_CHANGE --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: nikothedude <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1882
Original PR: tgstation/tgstation#82542
About The Pull Request
This should properly fix the post-blob-win audio/notif spam for real this time.
I wanted to preserve the effect as much as possible, so they just don't poll for ghosts when the round is already over.
Why It's Good For The Game
Closes #80998 for real this time.
Changelog
🆑 Rhials
fix: The tide of post-round blob zombies when a blob wins will no longer break the speakers in your headset.
/:cl: