Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Simple fix for Unicode in #591 #2811

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: NovaSector/NovaSector#1891

About The Pull Request

Hello! Just simple fix for that issues:

M60TUU8h5c.mp4

Proof of Testing

изображение
The fix doesn't break anything.

>>Here<<
HHdWDe3CqV.mp4

Changelog

🆑 RaShCat
fix: custom say able to use unicode.
/:cl:

missing _char

Co-authored-by: Archemagus <[email protected]>
@Iajret Iajret merged commit 2822404 into master Apr 10, 2024
26 checks passed
AnywayFarus added a commit that referenced this pull request Apr 10, 2024
@Iajret Iajret deleted the upstream-mirror-1891 branch April 10, 2024 14:44
Iajret pushed a commit that referenced this pull request Jun 3, 2024
* Adds Soup boiling SFX (#83649)

## About The Pull Request

In honor of the new sound effects general


https://github.com/tgstation/tgstation/assets/51863163/b2db8ee1-51ef-45a8-9cc8-31594d034ea5

Adds a sound effect that plays when soup is boiling (IE, it only plays
when smoke appears over the soup pot)

It has a sharp falloff and a distance penalty so it will really only be
heard in the kitchen (or though the kitchen's walls), maps with ranges
close to the counter like Metastation notwithstanding.

## Why It's Good For The Game

A touch of atmosphere

## Changelog

:cl: Melbert
sound: Boiling soup now makes a sound.
/:cl:

* Adds Soup boiling SFX

---------

Co-authored-by: MrMelbert <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants