Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] New Battle Arcade #2812

Merged
merged 1 commit into from
Apr 10, 2024
Merged

[MIRROR] New Battle Arcade #2812

merged 1 commit into from
Apr 10, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1870
Original PR: tgstation/tgstation#81810

About The Pull Request

Remakes Battle Arcade from just about the ground up, with exceptions taken for emagged stuff since I didn't really want to touch its behavior.

The Battle Arcade now has stages that players can go through, unlocking a stage by beating 2 enemies and the boss of the previous one, but this must all be done in a row. You can choose to take a break between each battle and there's a good chance you'll sleep just fine but there's also a chance it can go wrong either through an ambush or robbery.

The Inn lets you restore everything for 15 gold and you can buy a sword and armor, each level you unlock is a new sword and armor pair you can buy that's better than the last, it's 30 gold each but scales up as you progress through levels. They are really worth getting so it's best to try to not lose your money early in.

The battle system is nearly the same as how it was before but I removed the poor combo system that plagued the old arcade as one big knowledge lock, now it's more just turn based. The game is built on permadeath so dying means you restart from the beginning, but if you are going to lose you can try to escape instead which costs you half of your gold.

Getting to higher levels increases the difficulty of enemies but also increases the gaming exp rewards which could make this a better way to get exp if you can get good at it.

Gaming EXP is used to increase chances of counterattacking but doesn't give any extra health to the player.

I also removed the exploit of being able to screwdriver arcade cabinets because people would do that if they thought they were on the verge of losing to bypass the effects of loss. I instead replaced it with a new interaction that the Curator's display case key can be used to reset arcade cabinets (there's several keys on the chain so it made sense to me), which I added solely because I thought Curators would be the type of person to have run an actual arcade.

This is some gameplay
https://github.com/tgstation/tgstation/assets/53777086/499083f5-75cc-43b5-b457-017a012beede

As a misc sidenote, I also split up the arcade file just like how Orion Trail was before, just for neat code organization.
The Inn keeper is straight up just a photo of my localhost dude, he's not a player reference or anything it's not my actual character.
I also have no idea how well balanced this is cause I suck at it lol.

Why It's Good For The Game

Battle Arcade is one of 3 last machines in my hackmd here to turn into TGUI https://hackmd.io/XLt5MoRvRxuhFbwtk4VAUA?view
I've always thought the current version of battle arcade is quite lame and lacks any progression, like Orion Trail I thought that since I was moving this to TGUI, it would also be a perfect opportunity to revamp it and try to improve on where it failed before, especially since the alternative (NTOS Arcade) is also lame as hell and is even lamer than HTML battle arcade (spam mana, then spam health, then just spam attack, rinse and repeat).
This will hopefully be more entertaining and give players sense that they are getting through a series of tasks rather than doing one same one again and again.

Changelog

🆑 JohnFulpWillard, Zeek the Rat
add: Battle Arcade has been completely overhauled in a new progression system, this time using TGUI.
add: The Curator's keys can now reset arcade cabinets.
balance: You now need to be literate to play arcade games, except for Mediborg's Amputation Adventure.
fix: You can no longer screwdriver emagged arcade consoles. Accept your fate.
fix: Silicons can no longer play Mediborg's Amputation Adventure.
/:cl:

* New Battle Arcade

* Update ticker.dm

---------

Co-authored-by: John Willard <[email protected]>
Co-authored-by: Mal <[email protected]>
@ReezeBL ReezeBL merged commit 225d2bd into master Apr 10, 2024
26 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-1870 branch April 10, 2024 21:38
AnywayFarus added a commit that referenced this pull request Apr 10, 2024
Iajret pushed a commit that referenced this pull request Jun 3, 2024
* Fix null authors breaking test merge bot (#83640)

These can be null if they're ghost

* Fix null authors breaking test merge bot

---------

Co-authored-by: Mothblocks <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants