[MIRROR] Cleans up the SS13_base lua file and adds a new lua file for easily handling multiple signals on different objects. #2822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… easily handling multiple signals on different objects. (#1905) * Cleans up the SS13_base lua file and adds a new lua file for easily handling multiple signals on different objects. (#82458) ## About The Pull Request Cleaned up the SS13.register_signal and SS13.unregister_signal, removing the weird list shifting. Also adds a new lua file that can be included for the use of registering different signals on various datums and being able to clear them all in 1 function. Removed the make_easy_clear_function option when registering a signal via lua because I don't think it's used by anyone and it lacks any sort of versatility. Users can just create their own function for clearing signals from a datum. Also updates the documentation for HARDDELETES.md as COMSIG_PARENT_QDELETING was renamed to COMSIG_QDELETING ## Why It's Good For The Game New handler file makes registering signals in batches a lot easier if you want to clear them in one go without clearing unrelated callbacks on the same datum. The list shifting in SS13.register_signal had pretty significant performance problems, so removing that will make registering and unregistering signals faster. ## Changelog :cl: admin: LUA - Adds a new library called handler_group. Include it in your files by doing require('handler_group') /:cl: --------- Co-authored-by: Watermelon914 <[email protected]> * Cleans up the SS13_base lua file and adds a new lua file for easily handling multiple signals on different objects. --------- Co-authored-by: Watermelon914 <[email protected]> Co-authored-by: Watermelon914 <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Apr 10, 2024
Iajret
pushed a commit
that referenced
this pull request
Jun 4, 2024
* Fix Meta cargo lobby being unconnected to power (#83666) ## About The Pull Request Moves a misplaced wire to be connecting the cargo lobby APC instead of right next to it. Also adds a missing wire in maintenance from cargo's maintenance to the vault hallway and another one connecting the APC in the maintenance above mining. ## Why It's Good For The Game Allows meta's cargo lobby & mining maintence to actually charge without someone having to add a wire. ## Changelog :cl: Goat fix: meta's cargo lobby and mining maintenance APCs is now connected to the power line /:cl: * Fix Meta cargo lobby being unconnected to power --------- Co-authored-by: Goat <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Jun 5, 2024
* Fix Meta cargo lobby being unconnected to power (#83666) ## About The Pull Request Moves a misplaced wire to be connecting the cargo lobby APC instead of right next to it. Also adds a missing wire in maintenance from cargo's maintenance to the vault hallway and another one connecting the APC in the maintenance above mining. ## Why It's Good For The Game Allows meta's cargo lobby & mining maintence to actually charge without someone having to add a wire. ## Changelog :cl: Goat fix: meta's cargo lobby and mining maintenance APCs is now connected to the power line /:cl: * Fix Meta cargo lobby being unconnected to power --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: Goat <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1905
Original PR: tgstation/tgstation#82458
About The Pull Request
Cleaned up the SS13.register_signal and SS13.unregister_signal, removing the weird list shifting.
Also adds a new lua file that can be included for the use of registering different signals on various datums and being able to clear them all in 1 function.
Removed the make_easy_clear_function option when registering a signal via lua because I don't think it's used by anyone and it lacks any sort of versatility. Users can just create their own function for clearing signals from a datum.
Also updates the documentation for HARDDELETES.md as COMSIG_PARENT_QDELETING was renamed to COMSIG_QDELETING
Why It's Good For The Game
New handler file makes registering signals in batches a lot easier if you want to clear them in one go without clearing unrelated callbacks on the same datum. The list shifting in SS13.register_signal had pretty significant performance problems, so removing that will make registering and unregistering signals faster.
Changelog
🆑 Watermelon914
admin: LUA - Adds a new library called handler_group. Include it in your files by doing require('handler_group')
/:cl: