[MIRROR] Wraps lowertext() to ensure proper stringification.
#2824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Wraps `lowertext()` to ensure proper stringification. * Modular --------- Co-authored-by: san7890 <[email protected]> Co-authored-by: Mal <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Jun 4, 2024
* Fixes grammar in cat_house.dm (#83651) ## About The Pull Request Capitalizes and adds a period to the inspection text of the cat house. ## Why It's Good For The Game Grammar is good. I like grammar. ## Changelog :cl: spellcheck: Changed grammar in cat_house.dm /:cl: * Fixes grammar in cat_house.dm --------- Co-authored-by: vendingmachine24 <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Jun 5, 2024
* Fixes grammar in cat_house.dm (#83651) ## About The Pull Request Capitalizes and adds a period to the inspection text of the cat house. ## Why It's Good For The Game Grammar is good. I like grammar. ## Changelog :cl: spellcheck: Changed grammar in cat_house.dm /:cl: * Fixes grammar in cat_house.dm --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: vendingmachine24 <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1908
Original PR: tgstation/tgstation#82442
About The Pull Request
Fixes #82440
This PR just creates a new macro,
LOWER_TEXT()(yes the irony is not lost on me) to wrap around all calls oflowertext()and ensure that whatever we input into that proc will be stringified using the"[]"(ortostring()for the nerds) operator. very simple.I also added a linter to enforce this (and prevent all forms of regression) because I think that machines should do the menial work and we shouldn't expect maintainers to remember this, let me know if you disagree. if there is a time when it should be opted out for some reason, the linter does respect it if you wrap your input with the
UNLINT()function.