[MIRROR] Fixes a TG mirror i accidentialy Broke #2827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iajret
pushed a commit
that referenced
this pull request
Jun 4, 2024
* Fixes incorrect arguments in Status Displays (#83611) ## About The Pull Request Introduced in #83296 (9c58d7d1b9bd9cd447289cb02d0c49772b75a24a) Args for `generate_status_text()`: `line_y, message, x_offset, text_color, header_text_color, line_pair` The positional args we were feeding it via `/obj/machinery/status_display/proc/update_message()`: `line_y, message, text_color, header_text_color, x_offset, line_pair` This PR just moves `x_offset` to the proper position so we aren't plugging the wrong numbers into the positional arguments. ## Why It's Good For The Game Was likely broken, now it is fixed. In my test case, I found that it would break really weirdly and badly without this fix and worked fine with this fix. Probably due to the keys actually working. Anyways this was almost definitely the correct behavior seeing as x_offset is always the third argument everywhere so ## Changelog :cl: fix: Status displays should now no longer sporadically randomly break when in the custom message mode /:cl: * Fixes incorrect arguments in Status Displays --------- Co-authored-by: san7890 <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Jun 5, 2024
* Fixes incorrect arguments in Status Displays (#83611) ## About The Pull Request Introduced in #83296 (9c58d7d1b9bd9cd447289cb02d0c49772b75a24a) Args for `generate_status_text()`: `line_y, message, x_offset, text_color, header_text_color, line_pair` The positional args we were feeding it via `/obj/machinery/status_display/proc/update_message()`: `line_y, message, text_color, header_text_color, x_offset, line_pair` This PR just moves `x_offset` to the proper position so we aren't plugging the wrong numbers into the positional arguments. ## Why It's Good For The Game Was likely broken, now it is fixed. In my test case, I found that it would break really weirdly and badly without this fix and worked fine with this fix. Probably due to the keys actually working. Anyways this was almost definitely the correct behavior seeing as x_offset is always the third argument everywhere so ## Changelog :cl: fix: Status displays should now no longer sporadically randomly break when in the custom message mode /:cl: * Fixes incorrect arguments in Status Displays --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: san7890 <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#1910
Not player facing as this will make the Changelog match up with what it is supposed to be, i just did a dumb while sleepy and broke the mirror