Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Baisc Bot "Commission Emote" Tweak #2835

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1914
Original PR: tgstation/tgstation#82549

About The Pull Request

  1. Simple bots use Manual Emotes like Basic Bots
  2. Re-ups the CD for emoting to commission bots to 60 seconds, as it was originally with Simple Bots
  3. Punctuates the manual emotes
  4. Deletes the fist bump message

Why It's Good For The Game

  1. Consistency.
  2. These messages get a little... a lot spammy when walking around the halls, especially if Robotics has made a few additional bots. The original implementation had a CD of 60 seconds, which the AI behavior halved. Upping it back up for consistency + less spam.
  3. Looks a little less shoddy.
  4. It's a cute message, but it's completely out of character for what the bots are supposed to be "doing". They're "saluting" their "commissioned officer", not meeting up with the bros. Also they don't have fists! I understand saluting with their "robot appendage" but they don't punch people!

Changelog

🆑 Melbert
qol: Basic Bots will use their "salute" emotes less often.
del: Basic bot fists.
/:cl:

* Baisc Bot "Commission Emote" Tweak (#82549)

## About The Pull Request

1. Simple bots use Manual Emotes like Basic Bots
2. Re-ups the CD for emoting to commission bots to 60 seconds, as it was
originally with Simple Bots
3. Punctuates the manual emotes
4. Deletes the fist bump message

## Why It's Good For The Game

1. Consistency. 
2. These messages get a little... a lot spammy when walking around the
halls, especially if Robotics has made a few additional bots. The
original implementation had a CD of 60 seconds, which the AI behavior
halved. Upping it back up for consistency + less spam.
3. Looks a little less shoddy. 
4. It's a cute message, but it's completely out of character for what
the bots are supposed to be "doing". They're "saluting" their
"commissioned officer", not meeting up with the bros. Also they don't
have fists! I understand saluting with their "robot appendage" but they
don't punch people!

## Changelog

:cl: Melbert
qol: Basic Bots will use their "salute" emotes less often. 
del: Basic bot fists. 
/:cl:

* Baisc Bot "Commission Emote" Tweak

---------

Co-authored-by: MrMelbert <[email protected]>
@ReezeBL ReezeBL merged commit df552ec into master Apr 11, 2024
26 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-1914 branch April 11, 2024 15:00
AnywayFarus added a commit that referenced this pull request Apr 11, 2024
Iajret pushed a commit that referenced this pull request Jun 4, 2024
…lly-placed cave biome needs! (#2835)

* Adds Biomes to the Cave Generator, for all of your procedurally-placed cave biome needs!

* Update turf.dm

---------

Co-authored-by: GoldenAlpharex <[email protected]>
Co-authored-by: Mal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants