Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] [MODULAR] Makes Tajarans able to land on their feet #2844

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: NovaSector/NovaSector#1907

About The Pull Request

This PR makes Tajarans able to land on their feet if they fall through z-levels by giving them the TRAIT_CATLIKE_GRACE. It also adds the according perk on the species list page (as shown in the video).

How This Contributes To The Nova Sector Roleplay Experience

Because they're lowkey cats and it'd make sense - and because apparently this is what the code intended (kind of?) It offers variety and makes the trait (that's gatekept to felinids) available to other species that share, even if slightly, the same concept.

Proof of Testing

Screenshots/Videos forgive the 506p ^_^
MedalTVScreenRecording20240410155951-1712776011.mp4

Changelog

🆑 Chelxox
balance: Tajarans are able to land on their feet (like felinids).
/:cl:

* makes tajarans able to land on their feet like felinids

* Update tajaran.dm
@Iajret Iajret merged commit be45664 into master Apr 12, 2024
26 checks passed
@Iajret Iajret deleted the upstream-mirror-1907 branch April 12, 2024 18:06
AnywayFarus added a commit that referenced this pull request Apr 12, 2024
Iajret pushed a commit that referenced this pull request Jun 6, 2024
* Minor maintenance for plumbing (#83629)

## About The Pull Request
**1. Qol**
 - Screentips & examines for welder, wrench & plunger tools
- Examining plumbing machinery will display the reagents & their
respective volumes present inside
- Plumbing grinder now has a grind/juice mode which can be changed by
hand
 
**2. Code Improvements**
- Rapid plumbing device now uses the new attack
chain(`interact_with_atom()` & `interact_with_atom_secondary()`) instead
of the general `attackby()`
 - Same attack chain improvements applied for plumbing grinder
- Plumbing grinder now processes items that enter into it asynchronously

**3. Fixes**
 - Fixes #83538. Contains various sub changes
- You can now attack the plumbing grinder with any item in combat mode
without the grinder trying to consuming it
- You can deconstruct the plumbing grinder with the Rapid plumbing
device without the grinder trying to consuming it
- You cannot grind abstract & hologram items in the plumbing grinder
- Growing vat now uses the correct layer selected on rapid plumbing
device

## Changelog
:cl:
qol: more examines & screentips for plumbing machinery
qol: plumbing grinder has a grind/juice mode which be toggled by hand
code: improved attack chain for RPLD & plumbing grinder
fix: You can deconstruct the plumbing grinder with the RPLD
fix: You can attack the plumbing grinder with any item in combat mode
without getting that item consumed
fix: You cannot grind abstract/ hologram items in the plumbing grinder
fix: growing vat now uses the correct layer selected on rapid plumbing
device
/:cl:

* Minor maintenance for plumbing

---------

Co-authored-by: SyncIt21 <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants