Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] QOL for BMD, Interdyne, Freighter, DS2 #2860

Merged
merged 1 commit into from
Apr 14, 2024
Merged

Conversation

Steals-The-PRs
Copy link
Collaborator

Original PR: NovaSector/NovaSector#1929

About The Pull Request

So I've never been a fan of using 50 RTG's or a bluespace SMES to power the ghost roles, so this brings in a shinier and more practical item the micro reactor. After the power refactors and what not the need for this kind of exploded as well.

Currently it's set to generate 200 KW but i'm chewing on lowering it to 150, but currently doing anything above the baselines for all stations will eat up more than 200 so i'm sorta-kinda-ok with that value currently.

How This Contributes To The Nova Sector Roleplay Experience

Proof of Testing

Screenshots/Videos

image

image

Changelog

🆑 Zergspower
add: Adds a new powersource - A miniature Reactor - for ghost roles to replace bluespace SMES and the need to RTG Spam
qol: BMD now has a mining scanner! Gone are the days of accidentally blowing your home apart trying to get silver to make one
qol: Freighter, DS2 and Ice Interdyne receive a new reactor to give baseline power
/:cl:

* QOL for BMD, Interdyne, Freighter, DS2

* Update machinery.dm

* icedyne apc's

* why was that wired like that...

---------

Co-authored-by: SomeRandomOwl <[email protected]>
@Iajret Iajret merged commit 9193861 into master Apr 14, 2024
26 checks passed
@Iajret Iajret deleted the upstream-mirror-1929 branch April 14, 2024 10:10
AnywayFarus added a commit that referenced this pull request Apr 14, 2024
Iajret pushed a commit that referenced this pull request Jun 6, 2024
…rgument [MDB IGNORE] (#2860)

* Fixes COMSIG_ATOM_POST_DIR_CHANGE sending the wrong oldDir argument (#83727)

## About The Pull Request

It didn't cache dir, so it just sent newDir. 
## Why It's Good For The Game

im starting to hate this signal
## Changelog
:cl:
fix: COMSIG_ATOM_POST_DIR_CHANGE should ACTUALLY work now
/:cl:

* Fixes COMSIG_ATOM_POST_DIR_CHANGE sending the wrong oldDir argument

---------

Co-authored-by: nikothedude <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants