[MIRROR] [MODULAR] Adds *esigh, for exasperated sighing (With sounds) #2864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnywayFarus
added a commit
that referenced
this pull request
Apr 13, 2024
Iajret
pushed a commit
that referenced
this pull request
Jun 6, 2024
…ORE] (#2864) * Fixes tool-based flashes being stuck at intensity 1 (#83703) ## About The Pull Request A long-old bug due to the use of `min(flash_strength, 1)`. The intention was clearly to have the flash be *at least* level 1, because flash_strength defaults to nothing but can be set to 2. However, `min(x,y)` uses the lowest value, making it always return 1. So we change it to `max()`. ## Why It's Good For The Game Bugfix. Sunglasses users cope. ## Changelog :cl: fix: Tool-based flashes (read: from welders) are no longer incorrectly locked at flash level 1. Wear proper PPE! /:cl: * Fixes tool-based flashes being stuck at intensity 1 --------- Co-authored-by: zxaber <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#1851
About The Pull Request
Title.
keys are *esigh and *eisghs.
"[x] lets out an exasperated sigh."
How This Contributes To The Nova Sector Roleplay Experience
*sigh doesnt actually sound like a proper sigh, lets be real. Nobody sighs like that most of the time. *esigh is actually a much more realistic sigh.
See proof of testing for sounds.
Proof of Testing
Screenshots/Videos
2024-04-06.21-24-54.mp4
Changelog
🆑 nikothedude
add: *esigh, for exasperated sighing
/:cl: