[MIRROR] Fix buckled alert unbuckling not working properly #2875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix buckled alert unbuckling not working properly (#82627) ## About The Pull Request So funny thing, while trying to reproduce a different issue on the current master, I coincidentally let my local instance start without reading, latejoined on the shuttle, and I noticed it wasn't letting me unbuckle as easily. Looking into this a bit later, it seems as if it's a line #82593 accidentally changed while moving around the `/mob/living/carbon/resist_buckle()` proc's flow. https://github.com/tgstation/tgstation/blob/fe26373572e41415ec12e2b0785f0c6dc2567577/code/modules/mob/living/carbon/carbon.dm#L238-L241 While before it was ```dm /mob/living/carbon/resist_buckle() if(HAS_TRAIT(src, TRAIT_RESTRAINED)) (...) else buckled.user_unbuckle_mob(src,src) ``` Just changing this to `buckled.user_unbuckle_mob(src, src)` fixes this. ## Why It's Good For The Game Fixes buckled alert unbuckling not working properly. Fixes #82627. ## Changelog :cl: fix: Clicking the buckled alert unbuckles you again. /:cl: * Fix buckled alert unbuckling not working properly --------- Co-authored-by: _0Steven <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Apr 14, 2024
Iajret
pushed a commit
that referenced
this pull request
Jun 6, 2024
…2875) * Little QOL change for AI cyborg display power (#83625) ## About The Pull Request Slightly changes the formating from ugly 1e777 numbers to neat Jules format. ## FROM  ## TO  ## Why It's Good For The Game Much prettier stat panel and easier to read ## Changelog :cl: qol: Cyborgs on AI statpanel now have jules energy format. /:cl: * Little QOL change for AI cyborg display power --------- Co-authored-by: Erol509 <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1966
Original PR: tgstation/tgstation#82627
About The Pull Request
So funny thing, while trying to reproduce a different issue on the current master, I coincidentally let my local instance start without reading, latejoined on the shuttle, and I noticed it wasn't letting me unbuckle as easily.
Looking into this a bit later, it seems as if it's a line #82593 accidentally changed while moving around the
/mob/living/carbon/resist_buckle()proc's flow.https://github.com/tgstation/tgstation/blob/fe26373572e41415ec12e2b0785f0c6dc2567577/code/modules/mob/living/carbon/carbon.dm#L238-L241
While before it was
Just changing this to
buckled.user_unbuckle_mob(src, src)fixes this.Why It's Good For The Game
Fixes buckled alert unbuckling not working properly.
Fixes #82627.
Changelog
🆑 00-Steven
fix: Clicking the buckled alert unbuckles you again.
/:cl: