Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Security photobooths have their own ID #2878

Merged
merged 1 commit into from
Apr 14, 2024
Merged

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1963
Original PR: tgstation/tgstation#82628

About The Pull Request

Prevents the HoP's photobooth button from connecting to the security photobooth via having the same ID.

Why It's Good For The Game

I forgot to add this when I made the security photobooth but it's important that by default without any varedits, the HoP and security photobooths stay separate.

Changelog

🆑 JohnFulpWillard
fix: The HoP's photobooth button is now consistently connected to the HoP's photobooth.
/:cl:

* Security photobooths have their own ID (#82628)

## About The Pull Request

Prevents the HoP's photobooth button from connecting to the security
photobooth via having the same ID.

## Why It's Good For The Game

I forgot to add this when I made the security photobooth but it's
important that by default without any varedits, the HoP and security
photobooths stay separate.

## Changelog

:cl:
fix: The HoP's photobooth button is now consistently connected to the
HoP's photobooth.
/:cl:

* Security photobooths have their own ID

---------

Co-authored-by: John Willard <[email protected]>
@ReezeBL ReezeBL merged commit 76e9fd6 into master Apr 14, 2024
26 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-1963 branch April 14, 2024 19:06
AnywayFarus added a commit that referenced this pull request Apr 14, 2024
Iajret pushed a commit that referenced this pull request Jun 13, 2024
* wwaah

* yey

* Apply suggestions from code review

Co-authored-by: Bloop <[email protected]>

* Apply suggestions from code review

Co-authored-by: GoldenAlpharex <[email protected]>

* properly checks for entombed suits. Woops!

---------

Co-authored-by: Bloop <[email protected]>
Co-authored-by: GoldenAlpharex <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants