Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Removes redundant update_parallax_contents calls #2891

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1992
Original PR: tgstation/tgstation#82644

About The Pull Request

Off shuttle move doesn't need to happen because shuttles use abstract move which calls it anyway
Similar story for the ghost stuff, this was actually causing pretty common double calls so we may actually get somethin out of this Oh and something in air which is past me knifing me in the back

* Removes redundant update_parallax_contents calls (#82644)

## About The Pull Request

Off shuttle move doesn't need to happen because shuttles use abstract
move which calls it anyway
Similar story for the ghost stuff, this was actually causing pretty
common double calls so we may actually get somethin out of this Oh and
something in air which is past me knifing me in the back

* Removes redundant update_parallax_contents calls

---------

Co-authored-by: LemonInTheDark <[email protected]>
@mogeoko mogeoko merged commit 4eff60a into master Apr 15, 2024
26 checks passed
@mogeoko mogeoko deleted the upstream-mirror-1992 branch April 15, 2024 20:07
Iajret pushed a commit that referenced this pull request Jun 8, 2024
#2891)

* [NO GBP] Post-Rust Heretic's Rework adjustments. (#83765)

## About The Pull Request
Fixes antimagic, not preventing the disgust builtup from standing on
rusted tiles, makes rust walkers more expensive to summon.
## Why It's Good For The Game

I'm very happy with the end result of my Rust heretic rework; but they
came up a tad stronger than i wanted them to be.

Carlac already changed the Vomit stun to knockdown, but i wanted to add
a couple of things myself.

Having anti magic now makes you fully immune to the effects of rusted
tiles, not just the spells.

Rust walkers summoning ritual now requires titanium instead of iron
sheets.

As of right now, they are way too easy to spam, Titanium is a bit harder
to come by than iron so that'll do for now.

I was planning to set a limit to how many you can summon at the time,
but i'd rather wait a few months to see how rust behaves before i add
more nerfs.
## Changelog
:cl:
balance: Rust walkers' summoning ritual now requires 5 sheets of
Titanium instead of Iron.
fix: Magic resistance grants complete immunity from the passive disgust
buildup from standing on Rusted turfs.
/:cl:

* [NO GBP] Post-Rust Heretic's Rework adjustments.

---------

Co-authored-by: EnterTheJake <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants