Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Makes TGchat General settings better #2892

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1993
Original PR: tgstation/tgstation#82652

About The Pull Request

Removes dropdowns from General settings tab into TGchat
Replace it with map() and Collapsible

Before After
image image

Why It's Good For The Game

Dropdowns sucks. At least in TGchat settings, it's not the first time they've been broken, but now it's trivially extremely inconvenient.
Now, it's faster to change the theme/font, plus a font preview has been added, as it was before with GoonChat

Video
dreamseeker_oqDKXvNwBY.mp4

Changelog

🆑 AyIong
qol: General settings tab into TGchat, looks better now, and is more convenient to use. Also, each button has a font written on it.
/:cl:

* Makes TGchat General settings better (#82652)

## About The Pull Request
Removes dropdowns from General settings tab into TGchat
Replace it with map() and Collapsible

| Before | After |
| - | - |
|
![image](https://github.com/tgstation/tgstation/assets/69762909/b9956aef-3c99-4ec0-b7bd-d23db75a9c71)
|
![image](https://github.com/tgstation/tgstation/assets/69762909/35504396-99a7-402c-97b6-3496013d9b2b)
|

## Why It's Good For The Game
Dropdowns sucks. At least in TGchat settings, it's not the first time
they've been broken, but now it's trivially extremely inconvenient.
Now, it's faster to change the theme/font, plus a font preview has been
added, as it was before with GoonChat

<details>
<summary>Video</summary>


https://github.com/tgstation/tgstation/assets/69762909/b440db53-e78e-4440-ba33-b8e7ecade00a
</details>



## Changelog

:cl:
qol: General settings tab into TGchat, looks better now, and is more
convenient to use. Also, each button has a font written on it.
/:cl:

* Makes TGchat General settings better

---------

Co-authored-by: Aylong <[email protected]>
@mogeoko mogeoko merged commit e951a85 into master Apr 15, 2024
26 checks passed
@mogeoko mogeoko deleted the upstream-mirror-1993 branch April 15, 2024 20:08
AnywayFarus added a commit that referenced this pull request Apr 15, 2024
Iajret pushed a commit that referenced this pull request Jun 8, 2024
* Fix smoking pipe sprite typo (#83759)

## About The Pull Request
closes #83755 
there was a typographical error in both of the item
## Why It's Good For The Game
it closes #83755 
## Changelog
:cl:
fix: smoking pipe not showing sprite when lit
/:cl:

* Fix smoking pipe sprite typo

---------

Co-authored-by: projectkepler-RU <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
Co-authored-by: FlufflesTheDog <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants