[MIRROR] Patches & renaming for NO_DECONSTRUCTION flag
#2897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * [NO GBP] Patches & renaming for `NO_DECONSTRUCTION` flag (#82547) ## About The Pull Request 1. Renames `NO_DECONSTRUCTION` -> `NO_DEBRIS_AFTER_DECONSTRUCTION`. As the name suggests when the object is deconstructed it won't drop any items/debris. After my last refactor for this flag it now serves a new purpose so its name has been changed to match that 2. Fixes objects that are now using `NO_DECONSTRUCTION` incorrectly. Some of these changes include - Removing the flag in objects where there are no means to deconstruct them (e.g. jukebox, hydroponics soil, flora etc) - Replacing the flags old purpose by overriding its tool procs so that it regains its old behaviour(e.g. You once again cannot deconstruct ctf reinforced tables, survival pods, indestructible windows etc) ## Changelog :cl: code: renamed `NO_DECONSTRUCTION` to `NO_DEBRIS_AFTER_DECONSTRUCTION` so its name matches its intended purpose fix: fixes some items that incorrectly used `NO_DECONSTRUCTION` prior to its refactor, meaning makes some objects non deconstructable again /:cl: * [NO GBP] Patches & renaming for `NO_DECONSTRUCTION` flag * Update colony_fabricator.dm * renames, this probally needs testing * just a test * Revert "renames, this probally needs testing" This reverts commit 8f3490c95e03869079260824789a73bc0de06481. * Revert "[MODULAR] Adds an entirely new map to Nova's roster: Ouroboros! (#773)" This reverts commit 56a100f88677bfb3af7814549b8e4fbf5a0faeb4. * Fixes most of our items hopefully to work with the new lack of flag * Reapply "[MODULAR] Adds an entirely new map to Nova's roster: Ouroboros! (#773)" This reverts commit 2b063ae4c5680c7d3eef90615dbc28d59d2cdf15. * Additional missed things/fixing mistakes * But wait there's more * Update lavaland_surface_prefab_homestead.dmm --------- Co-authored-by: SyncIt21 <[email protected]> Co-authored-by: SomeRandomOwl <[email protected]> Co-authored-by: Mal <[email protected]>
…into upstream-mirror-1917
AnywayFarus
added a commit
that referenced
this pull request
Apr 16, 2024
Iajret
pushed a commit
that referenced
this pull request
Jun 8, 2024
…lacklisted map framework to modifiers [MDB IGNORE] (#2897) * Adds a random martial arts modifier to deathmatch + Adds a blacklisted map framework to modifiers (#83465) ## About The Pull Request Title. Uses pickweight, to ensure rare martial arts stay rare. Common: * Carp * CQC Uncommon: * EVIL boxing LEGENDARY: * Wrestling * UNNERFED PLASMA FIST * Psychotic brawling (bath salts, rare because its a meme) Does not work on meat tower. ## Why It's Good For The Game Variety is good! Also, theres only one way to get martial arts in DM and thats meat tower. There is ALSO very little way to get evil boxing, mushpunch, plasmafist, etc. This allows people to go absolutely nuts in death match, and I think thats a good thing. ## Changelog :cl: add: New deathmatch modifier: "Random martial arts" /:cl: * Adds a random martial arts modifier to deathmatch + Adds a blacklisted map framework to modifiers --------- Co-authored-by: nikothedude <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1917
Original PR: tgstation/tgstation#82547
About The Pull Request
Renames
NO_DECONSTRUCTION->NO_DEBRIS_AFTER_DECONSTRUCTION. As the name suggests when the object is deconstructed it won't drop any items/debris. After my last refactor for this flag it now serves a new purpose so its name has been changed to match thatFixes objects that are now using
NO_DECONSTRUCTIONincorrectly. Some of these changes includeChangelog
🆑 SyncIt21
code: renamed
NO_DECONSTRUCTIONtoNO_DEBRIS_AFTER_DECONSTRUCTIONso its name matches its intended purposefix: fixes some items that incorrectly used
NO_DECONSTRUCTIONprior to its refactor, meaning makes some objects non deconstructable again/:cl: