[MIRROR] Fixes SMES terminal placing under the SMES and not under the player #2908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… player (#2003) * Fixes SMES terminal placing under the SMES and not under the player (#82665) ## About The Pull Request Changes `src` to`user` to get intended behavior. * Fixes SMES terminal placing under the SMES and not under the player --------- Co-authored-by: Iajret <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Apr 16, 2024
Iajret
pushed a commit
that referenced
this pull request
Jun 8, 2024
…IGNORE] (#2908) * Fix admin borg panel unable to install/remove upgrades (#83733) ## About The Pull Request Fixes the admin borg panel's upgrade functionality. Caused by not registering the signals for deletion and also by the upgrade code checking the robot's contents instead of upgrades list (since the borg panel spawns the item in the borg, it appears in the borg's contents, making the check think the borg already has it installed.) ## Why It's Good For The Game Easier testing new borg modules ## Changelog :cl: fix: Fixes admin borg panel upgrade functions /:cl: * Fix admin borg panel unable to install/remove upgrades --------- Co-authored-by: thegrb93 <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#2003
Original PR: tgstation/tgstation#82665
About The Pull Request
Changes
srctouserto get intended behavior.Why It's Good For The Game
if only we had a way to place both input and output on a single turf....
Changelog
🆑 Iajret
fix: wiring newly built SMESes should place new teminal under the player and not under the SMES itself.
/:cl: