[MIRROR] Anomaly Releaser logging and fixes #2913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Anomaly Releaser logging and fixes (#82684) ## About The Pull Request I literally do not think I have heard of anyone using this extremely niche space ruin item a single time. _**However**_ if they did it wasn't logged, so now it is. Additionally I found a bunch of bugs while testing it: - You could queue inputs on a bunch of cores and activate all of them at once because it didn't check if had been expended by a concurrent do_after. - It made normally immobile anomalies mobile. - I broke immobility in general in a recent PR, but also it's redundant with a different var I added. I fixed all of these. ## Why It's Good For The Game For the one round that will happen in tg history where someone reactivates a Vortex Anomaly Core on the escape shuttle, it should log who did it. ## Changelog :cl: admin: Reactivating an anomaly core via the anomaly releaser is now logged. fix: Fixes various bugs related to dimensional/spectral anomalies moving when they should not. /:cl: * Anomaly Releaser logging and fixes --------- Co-authored-by: Jacquerel <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Apr 16, 2024
Iajret
pushed a commit
that referenced
this pull request
Jun 8, 2024
…RE] (#2913) * Makes The Automute Thingo Yell At You A Bit Louder (#83636) ## About The Pull Request It makes the automute use bigger, redder text and also balloon alert I know ppl dont like punctuation in balloon alerts so I can remove the exclamation mark if u want, i like it tho I guess if u support darwinism u could leave it as is but in the era of runetext and TTS ppl cant pay attention to the chat window they're too busy watching subway surfers on their second monitor and scrolling tiktok on their phone Doesnt change the text so it stays deliberately vague like the comment says it should Before: <img src="https://i.ibb.co/3hDnpQm/Automute-Before.png"> After: <img src="https://i.ibb.co/0qSwJFB/Automute-After.png"> <img src="https://i.ibb.co/n3ch9fg/Automute-Balloon-Alert.png"> ## Why It's Good For The Game Being automuted when there's no admins on cuz u got a bit carried away isnt cool and then u have to urgent ahelp it, which is understandable cuz it's making the round unplayable for you but you did kinda bring it on yourself and the admin might not be too happy with you about it. ## Changelog :cl: admin: The auto-mute system yells at you harder when you send a bunch of identical messages. /:cl: * Makes The Automute Thingo Yell At You A Bit Louder --------- Co-authored-by: Jackraxxus <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#2010
Original PR: tgstation/tgstation#82684
About The Pull Request
I literally do not think I have heard of anyone using this extremely niche space ruin item a single time.
However if they did it wasn't logged, so now it is.
Additionally I found a bunch of bugs while testing it:
I fixed all of these.
Why It's Good For The Game
For the one round that will happen in tg history where someone reactivates a Vortex Anomaly Core on the escape shuttle, it should log who did it.
Changelog
🆑 Jacquerel
admin: Reactivating an anomaly core via the anomaly releaser is now logged.
fix: Fixes various bugs related to dimensional/spectral anomalies moving when they should not.
/:cl: