[MIRROR] Small optimization for Aura Healing #2928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Small optimization for Aura Healing (#82674) ## About The Pull Request - Makes use of the byond internal optimization for `view` to speed up aura healing a tiny bit. - In case you didn't know, byond has an optimization for `view` which speeds up iterating over objects in view if you provide it a type. This use of a ternary (likely) prevented this optimization from kicking in, and since worst-case we're doing view(7) it can add up. - Test case: 2 staff of Ascelpius users surrounded by 15 humans and 15 random objects constant being damaged. ~8 minutes of testing. - Profile: ``` /datum/component/aura_healing/proc/heal_old 0.789 6.590 6.596 0.000 4076 /datum/component/aura_healing/proc/heal_new 0.682 6.443 6.442 0.000 4081 ``` - Generalizes `SSaura_healing` to `SSaura`, makes "damage aura" component (which is totally 99% copied from "healing aura" but that's for another pr) use it as well ## Changelog :cl: Melbert refactor: Staff of Healing should perform slightly better. /:cl: * Small optimization for Aura Healing --------- Co-authored-by: MrMelbert <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Apr 17, 2024
Iajret
pushed a commit
that referenced
this pull request
Jun 9, 2024
* Removes the unpowered door subtype (#83812) ## About The Pull Request They appear to be giga legacy, only thing using them is one what appears to be totally unused small template shuttle. I just replaced em with titanium airlocks, since I think that's what these were replaced with going off asthetic. (I do not want to deal with this for wallening) * Removes the unpowered door subtype --------- Co-authored-by: LemonInTheDark <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#2026
Original PR: tgstation/tgstation#82674
About The Pull Request
viewto speed up aura healing a tiny bit.In case you didn't know, byond has an optimization for
viewwhich speeds up iterating over objects in view if you provide it a type. This use of a ternary (likely) prevented this optimization from kicking in, and since worst-case we're doing view(7) it can add up.Test case: 2 staff of Ascelpius users surrounded by 15 humans and 15 random objects constant being damaged. ~8 minutes of testing.
Profile:
SSaura_healingtoSSaura, makes "damage aura" component (which is totally 99% copied from "healing aura" but that's for another pr) use it as wellChangelog
🆑 Melbert
refactor: Staff of Healing should perform slightly better.
/:cl: